7342 edit this translation #7389
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
apps/site/components/withMetaBar.tsx:62
- Ensure the translation key 'components.metabar.contributeText' is defined and covered by tests.
{t('components.metabar.contributeText')}
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
|
I'm not 100% a fan. I think that if it's the default language, we should have ‘edit content’ and if it's another language we should have ‘edit source content’ and if translation is available for this page we should have ‘translate this page’. It might be possible to move forward with this pr to avoid problems. And open an exit to have this feature more ‘fancy’. |
Thanks for sharing your opinion. Re-reading #7342 (comment), you probably would have wanted something more nuanced. I went with this approach after realizing we have already been translating this string, just not using it. Changing it will take time.
Would you be okay with this solution as an improvement on the existing state? I took it up during some downtime to improve reader/contributor UX. |
yeah let's merge with actual state and then open another change |
Description
Usesthe (already, but unused)
edit this pagetranslation in the metabar, and conditionally sends the user to the appropriate resourceValidation
Live
Rendering
en(default)locale: the url resolves as usualRelated Issues
closes #7342
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.