Skip to content

7342 edit this translation #7389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmuenzenmeyer merged 2 commits into from
Jan 8, 2025
Merged

7342 edit this translation #7389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f447e5b
use translation
bmuenzenmeyer Jan 6, 2025
503ae13
feat: translate "Edit this page", linking appropriately based on locale
bmuenzenmeyer Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions apps/site/components/withMetaBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';

import { useFormatter } from 'next-intl';
import { useFormatter, useLocale, useTranslations } from 'next-intl';
import type { FC } from 'react';

import MetaBar from '@/components/Containers/MetaBar';
Expand All @@ -10,6 +10,8 @@ import WithAvatarGroup from '@/components/withAvatarGroup';
import { useClientContext } from '@/hooks/react-client';
import useMediaQuery from '@/hooks/react-client/useMediaQuery';
import { DEFAULT_DATE_FORMAT } from '@/next.calendar.constants.mjs';
import { TRANSLATION_URL } from '@/next.constants.mjs';
import { defaultLocale } from '@/next.locales.mjs';
import { getGitHubBlobUrl } from '@/util/gitHubUtils';

const WithMetaBar: FC = () => {
Expand All @@ -22,6 +24,9 @@ const WithMetaBar: FC = () => {
const usernames =
frontmatter.authors?.split(',').map(author => author.trim()) ?? [];

const t = useTranslations();
const locale = useLocale();

// Since we cannot show the same number of avatars in Mobile / Tablet
// resolution as we do on desktop and there is overflow, we are adjusting
// the number of avatars manually for the resolutions below
Expand All @@ -47,7 +52,15 @@ const WithMetaBar: FC = () => {
'components.metabar.contribute': (
<>
<GitHub className="fill-neutral-700 dark:fill-neutral-100" />
<Link href={getGitHubBlobUrl(filename)}>Edit this page</Link>
<Link
href={
locale === defaultLocale.code
? getGitHubBlobUrl(filename)
: TRANSLATION_URL
}
>
{t('components.metabar.contributeText')}
</Link>
</>
),
}}
Expand Down
6 changes: 6 additions & 0 deletions apps/site/next.constants.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,3 +187,9 @@ export const ORAMA_CLOUD_API_KEY =
* Note: This has no NEXT_PUBLIC prefix as it should not be exposed to the Browser.
*/
export const GITHUB_API_KEY = process.env.NEXT_GITHUB_API_KEY || '';

/**
* The resource we point people to when discussing internationalization efforts.
*/
export const TRANSLATION_URL =
'https://github.com/nodejs/nodejs.org/blob/main/TRANSLATION.md#how-to-translate';
Loading