-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(badge): add next-10 #7726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- apps/site/site.json: Language not supported
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Lighthouse Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7726 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 98 98
Lines 7888 7888
Branches 200 200
=======================================
Hits 5903 5903
Misses 1984 1984
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@AugustinMauroy the badge for JSConf shouldn’t be removed, please. I rather make the Next-10 survey a banner; but the EOL banner is also important I assume. The JSConf badge is due to be removed end o May |
|
We agree that we won't touch the banner because it's a safety issue. |
|
Following on what @AugustinMauroy said, We all know JSConf is important, but users have more time to sign up than they do to fill out Next-10 (IIRC), therefore, Next-10 (IMO) should be a higher priority |
mhdawson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I won’t sign this off without a +1 from the foundation. I know they will be 100% fine with this change, but just want an explicit/implicit 👍 so that they are aware of this change. cc @kyliewd |
|
Removing
fast-track
|
|
Thanks for the heads up. I am fine with having Next 10 replace JSConf for the month of May. However, after the survey is complete, I’d like to see JSConf back on the website as it’s not just an important event for the foundation, but also the node.js community. |
Description
Due to the lack of response because not all our users follow us on the networks, we need to put the survey in the spotlight.
Validation
Badge should be on landing page
Related Issues
No Related issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.