Skip to content

Conversation

@AugustinMauroy
Copy link
Member

Description

Due to the lack of response because not all our users follow us on the networks, we need to put the survey in the spotlight.

Validation

Badge should be on landing page

Related Issues

No Related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels May 6, 2025
Copilot AI review requested due to automatic review settings May 6, 2025 07:21
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner May 6, 2025 07:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/site.json: Language not supported

@vercel
Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 6, 2025 7:21am

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (b551775) to head (08a6d90).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7726   +/-   ##
=======================================
  Coverage   74.83%   74.83%           
=======================================
  Files          98       98           
  Lines        7888     7888           
  Branches      200      200           
=======================================
  Hits         5903     5903           
  Misses       1984     1984           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AugustinMauroy
Copy link
Member Author

cc @sheplu @marco-ippolito @kyliewd

@ovflowd
Copy link
Member

ovflowd commented May 6, 2025

@AugustinMauroy the badge for JSConf shouldn’t be removed, please. I rather make the Next-10 survey a banner; but the EOL banner is also important I assume. The JSConf badge is due to be removed end o May

@AugustinMauroy
Copy link
Member Author

We agree that we won't touch the banner because it's a safety issue.
On the other hand, the badge for the JSconf can be removed, as it's not directly the node project but the Foundation. What's more, next-10 also ends in May and we need as many users as possible to respond.
I'm convinced that the next-10 survey is more important than the JSconf.

@avivkeller
Copy link
Member

Following on what @AugustinMauroy said,

We all know JSConf is important, but users have more time to sign up than they do to fill out Next-10 (IIRC), therefore, Next-10 (IMO) should be a higher priority

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member

ovflowd commented May 6, 2025

I won’t sign this off without a +1 from the foundation. I know they will be 100% fine with this change, but just want an explicit/implicit 👍 so that they are aware of this change.

cc @kyliewd

@avivkeller avivkeller removed the fast-track Fast Tracking PRs label May 7, 2025
@avivkeller
Copy link
Member

Removing fast-track Fast Tracking PRs as IMO this should wait at least 48 hours from open to land, giving people in various areas of the foundation the time to weigh in, if needed.

@kyliewd
Copy link

kyliewd commented May 8, 2025

Thanks for the heads up. I am fine with having Next 10 replace JSConf for the month of May. However, after the survey is complete, I’d like to see JSConf back on the website as it’s not just an important event for the foundation, but also the node.js community.

@avivkeller avivkeller added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 866bb55 May 8, 2025
21 checks passed
@avivkeller avivkeller deleted the next-10-survey branch May 8, 2025 15:37
@Shubham2552 Shubham2552 mentioned this pull request May 28, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants