Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented May 26, 2025

  1. We need a version around 1.0.0
  2. NODE_AUTH_TOKEN rather than NPM_TOKEN

Signed-off-by: Aviv Keller <me@aviv.sh>
@vercel
Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 26, 2025 4:54pm

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.33%. Comparing base (3783f9f) to head (091dd21).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7780      +/-   ##
==========================================
+ Coverage   75.32%   75.33%   +0.01%     
==========================================
  Files          96       96              
  Lines        7861     7861              
  Branches      192      192              
==========================================
+ Hits         5921     5922       +1     
+ Misses       1939     1938       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas
Copy link
Member

FWIW: #7776 (comment)

npm only recognizes NODE_AUTH_TOKEN environment variable. Unfortunately, there is no doc on npm environs. But you can refer to https://docs.github.com/en/actions/use-cases-and-examples/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry.

@avivkeller avivkeller changed the title chore(publish): test publishing chore(publish): fix publishing May 26, 2025
@avivkeller avivkeller marked this pull request as ready for review May 26, 2025 16:49
Copilot AI review requested due to automatic review settings May 26, 2025 16:49
@avivkeller avivkeller requested a review from a team as a code owner May 26, 2025 16:49
@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels May 26, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow for publishing packages to:

  • Switch the npm auth environment variable from NPM_TOKEN to NODE_AUTH_TOKEN
  • Use a prerelease version starting at 1.0.1 instead of 0.0.0
  • Add --no-git-checks to the pnpm publish command

@avivkeller
Copy link
Member Author

Thanks @legendecas! I got confuseed with https://pnpm.io/using-changesets#add-the-workflow in the pnpm docs!

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 85 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 1815fa7 May 26, 2025
21 of 23 checks passed
@avivkeller avivkeller deleted the fix/workflow branch May 26, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants