Skip to content

chore(publish): fix publishing #7780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 7 commits into from
May 26, 2025
Merged

chore(publish): fix publishing #7780

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45765c3
chore(publish): test publishing
avivkeller May 26, 2025
e0ad12a
testing
avivkeller May 26, 2025
1bd9d35
testing
avivkeller May 26, 2025
f948ce8
testing
avivkeller May 26, 2025
fbc0bae
fixup
avivkeller May 26, 2025
0ddc9d7
fixup!
avivkeller May 26, 2025
091dd21
fixup!
avivkeller May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/publish-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,13 @@ jobs:
- name: Publish
working-directory: packages/${{ matrix.package }}
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
# Create a unique version using the commit SHA as a prerelease identifier
# This ensures we can publish multiple times from the same codebase with unique versions
npm version --no-git-tag-version 0.0.0-$COMMIT_SHA
npm version --no-git-tag-version 1.0.1-$COMMIT_SHA
# Publish the package to the npm registry with public access flag
pnpm publish --access public
pnpm publish --access public --no-git-checks

- name: Notify on Manual Release
if: ${{ github.event_name == 'workflow_dispatch' }}
Expand All @@ -142,7 +142,7 @@ jobs:
SLACK_ICON: https://github.com/nodejs.png?size=48
SLACK_TITLE: ':rocket: Package Published: ${{ matrix.package }}'
SLACK_MESSAGE: |
:package: *Package*: `${{ matrix.package }}` (<https://www.npmjs.com/package/${{ steps.package-info.outputs.name }}|View on npm>)
:package: *Package*: `${{ matrix.package }}` (<https://www.npmjs.com/package/@node-core/${{ matrix.package }}|View on npm>)
:bust_in_silhouette: *Published by*: ${{ github.triggering_actor }}
:octocat: *Commit*: <https://github.com/${{ github.repository }}/commit/${{ env.COMMIT_SHA }}|${{ env.COMMIT_SHA }}>
SLACK_USERNAME: nodejs-bot
Expand Down
Loading