Skip to content

Conversation

@araujogui
Copy link
Member

Description

Fixes a bug where the release modal didn't close when the user clicked the 'Understand EOL support' link.

Validation

Screen Recording 2025-06-27 at 15 45 02

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings June 27, 2025 18:45
@araujogui araujogui requested a review from a team as a code owner June 27, 2025 18:45
@vercel
Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 28, 2025 5:12pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the bug where the release modal remains open when the user clicks the "Understand EOL support" link.

  • Added an onClick handler (closeModal) to the Link component to close the modal on click.
  • Updated the href to point to "/about/previous-releases#release-schedule" for proper navigation.
Comments suppressed due to low confidence (1)

apps/site/components/Downloads/ReleaseModal/index.tsx:45

  • [nitpick] Consider evaluating if the onClick handler should prevent default navigation (e.g., via event.preventDefault) to ensure the modal is fully closed before the browser navigates to the new anchor. This can help prevent any potential race conditions between modal teardown and navigation.
                onClick={closeModal}

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (3615c30) to head (100dc89).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7903      +/-   ##
==========================================
- Coverage   75.47%   75.40%   -0.08%     
==========================================
  Files         101       96       -5     
  Lines        8311     8350      +39     
  Branches      218      219       +1     
==========================================
+ Hits         6273     6296      +23     
- Misses       2036     2052      +16     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd
Copy link
Member

ovflowd commented Jun 27, 2025

Nit, @araujogui could you:

  • Also move the warning banner to be above the title (Node.js 15)
  • Make the title be like Node.js v{version}
  • Update th copy so that it all fits in one line? Somehow it looks weird being a double decker warning with the "warn" label kinda misaligned 😅

@avivkeller
Copy link
Member

avivkeller commented Jun 27, 2025

Make the title be like Node.js v{version}

In https://github.com/nodejs/node/blob/main/CHANGELOG.md, they are just "Node.js {ver}"

image
Also just says "Node.js {ver}"

@ovflowd
Copy link
Member

ovflowd commented Jun 27, 2025

Make the title be like Node.js v{version}

In https://github.com/nodejs/node/blob/main/CHANGELOG.md, they are just "Node.js {ver}"

image Also just says "Node.js {ver}"

Yes, but in other places of the website we use v{x}, just want to keep it standard. (And that image is not within our domain/realm)

@ovflowd
Copy link
Member

ovflowd commented Jun 27, 2025

To be clear, I'm fine to be either Node v{x}; Node.js v{x}; or Node.js {x}; or Node {x}-- I just want consistency across the board :)

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM <3

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd ovflowd enabled auto-merge June 28, 2025 17:26
@ovflowd
Copy link
Member

ovflowd commented Jun 28, 2025

I'm fast-tracking this as a bug-fix. FYI @nodejs/nodejs-website

@ovflowd ovflowd added this pull request to the merge queue Jun 28, 2025
Merged via the queue into nodejs:main with commit a0f03ae Jun 28, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants