Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions app/composables/usePackageComparison.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type {
Packument,
VulnerabilityTreeResult,
} from '#shared/types'
import type { PackageLikes } from '#shared/types/social'
import { encodePackageName } from '#shared/utils/npm'
import type { PackageAnalysisResponse } from './usePackageAnalysis'
import { isBinaryOnlyPackage } from '#shared/utils/binary-detection'
Expand All @@ -14,6 +15,8 @@ import { getDependencyCount } from '~/utils/npm/dependency-count'
export interface PackageComparisonData {
package: ComparisonPackage
downloads?: number
/** Total likes from atproto */
totalLikes?: number
/** Package's own unpacked size (from dist.unpackedSize) */
packageSize?: number
/** Number of direct dependencies */
Expand Down Expand Up @@ -104,16 +107,16 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
if (!latestVersion) return null

// Fetch fast additional data in parallel (optional - failures are ok)
const [downloads, analysis, vulns] = await Promise.all([
const [downloads, analysis, vulns, likes] = await Promise.all([
$fetch<{ downloads: number }>(
`https://api.npmjs.org/downloads/point/last-week/${encodePackageName(name)}`,
).catch(() => null),
$fetch<PackageAnalysisResponse>(`/api/registry/analysis/${name}`).catch(() => null),
$fetch<VulnerabilityTreeResult>(`/api/registry/vulnerabilities/${name}`).catch(
() => null,
),
$fetch<PackageLikes>(`/api/social/likes/${name}`).catch(() => null),
])

const versionData = pkgData.versions[latestVersion]
const packageSize = versionData?.dist?.unpackedSize

Expand Down Expand Up @@ -160,6 +163,7 @@ export function usePackageComparison(packageNames: MaybeRefOrGetter<string[]>) {
deprecated: versionData?.deprecated,
},
isBinaryOnly: isBinary,
totalLikes: likes?.totalLikes,
}
} catch {
return null
Expand Down Expand Up @@ -269,6 +273,14 @@ function computeFacetValue(
status: 'neutral',
}
}
case 'totalLikes': {
if (data.totalLikes === undefined) return null
return {
raw: data.totalLikes,
display: formatCompactNumber(data.totalLikes),
status: 'neutral',
}
}
case 'packageSize': {
if (!data.packageSize) return null
return {
Expand Down
4 changes: 4 additions & 0 deletions i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,10 @@
"label": "Downloads/wk",
"description": "Weekly download count"
},
"totalLikes": {
"label": "Likes",
"description": "Number of likes"
},
"lastUpdated": {
"label": "Published",
"description": "When this version was published"
Expand Down
4 changes: 4 additions & 0 deletions i18n/locales/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,10 @@
"label": "Téléch./semaine",
"description": "Nombre de téléchargements par semaine"
},
"totalLikes": {
"label": "Likes",
"description": "Nombre de likes"
},
"lastUpdated": {
"label": "Publié",
"description": "Quand cette version a été publiée"
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/en-GB.json
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,10 @@
"label": "Downloads/wk",
"description": "Weekly download count"
},
"totalLikes": {
"label": "Likes",
"description": "Number of likes"
},
"lastUpdated": {
"label": "Published",
"description": "When this version was published"
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,10 @@
"label": "Downloads/wk",
"description": "Weekly download count"
},
"totalLikes": {
"label": "Likes",
"description": "Number of likes"
},
"lastUpdated": {
"label": "Published",
"description": "When this version was published"
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -891,6 +891,10 @@
"label": "Téléch./semaine",
"description": "Nombre de téléchargements par semaine"
},
"totalLikes": {
"label": "Likes",
"description": "Nombre de likes"
},
"lastUpdated": {
"label": "Publié",
"description": "Quand cette version a été publiée"
Expand Down
4 changes: 4 additions & 0 deletions shared/types/comparison.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export type ComparisonFacet =
| 'dependencies'
| 'totalDependencies'
| 'deprecated'
| 'totalLikes'

/** Facet metadata for UI display */
export interface FacetInfo {
Expand Down Expand Up @@ -46,6 +47,9 @@ export const FACET_INFO: Record<ComparisonFacet, Omit<FacetInfo, 'id'>> = {
downloads: {
category: 'health',
},
totalLikes: {
category: 'health',
},
lastUpdated: {
category: 'health',
},
Expand Down
1 change: 1 addition & 0 deletions test/nuxt/components/compare/FacetSelector.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const facetLabels: Record<ComparisonFacet, { label: string; description: string
description: 'Total number of dependencies including transitive',
},
deprecated: { label: 'Deprecated?', description: 'Whether the package is deprecated' },
totalLikes: { label: 'Likes', description: 'Number of likes' },
}

const categoryLabels: Record<string, string> = {
Expand Down
Loading