Skip to content

Conversation

@reinkrul
Copy link
Member

@reinkrul reinkrul commented Dec 18, 2025

We used JSON-LD marshalling semantics for JWT VPs, which is incorrect; single-entry arrays shouldn't be flattened to singular values.

Found during LSPxNuts hackaton.

This applied to the following fields:

  • type
  • verifiableCredential
  • @context

Fixes #3957

@qltysh
Copy link

qltysh bot commented Dec 18, 2025

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
vcr/holder/presenter.go100.0%
Coverage rating: B Coverage rating: B
vcr/pe/presentation_submission.go100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@reinkrul reinkrul marked this pull request as draft December 18, 2025 13:29
@reinkrul reinkrul marked this pull request as ready for review December 24, 2025 13:18
@reinkrul reinkrul changed the title Fix VP JWT type marshalling being a []string Fix VP JWT marshalling flattening single-entry arrays incorrectly Dec 24, 2025
@reinkrul reinkrul changed the title Fix VP JWT marshalling flattening single-entry arrays incorrectly Bug: fix VP JWT marshalling flattening single-entry arrays incorrectly Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verifiable Presentation type is marshalled incorrectly in JWT format

2 participants