-
Notifications
You must be signed in to change notification settings - Fork 941
Mark declarative config as stable #4568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mark declarative config as stable #4568
Conversation
|
This is ready for review, but SHOULD not be merged. Assuming we get the required approvals, I'll coordinate merging this with cutting the corresponding release of |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…y-specification into stabilize-declarative-config
specification/configuration/sdk.md
Outdated
| * `component_provider` - The `ComponentProvider`. | ||
| * `type` - The type of plugin interface it provides (e.g. SpanExporter, Sampler, | ||
| etc). | ||
| * `type` - The type of plugin interface it provides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not like that in one place we are saying "component" in other "plugin" or "plugin interfaces".
I know that it keeps the same intention, but it makes me harder to read and interpret the specification.
I propose to use the term "Component" everywhere and just mention in the "Component" definition that this is a plugin that allows extensibility of the Configuration SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine with me. I was trying to connect the dots because elsewhere in the spec we both the words component and plugin interface. I'll try to be consistent here with "component" but also have a callout with something to the effect of: "... (also called plugin interface elsewhere in the spec)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
A concern I have is that this sort of implies that a spec for the behavior of Can the spec of config be stable before SDK initialization is defined? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
The config SIG has been making a lot of progress around the goal of stability and will be looking to stabilize end of 2025 / early 2026. Converting this to a draft until we're ready. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@tsloughter I don't understand. |
Resolves #4374.
We recently cut a release candidate for
opentelemetry-configuration. After some additional bake-in time and review, we'd like to cut a stable release.The stable release needs to coincide with marking key parts of the specification stable, so I'm opening this PR to solicit feedback such that when the time comes, we can mark the specification and
opentelemetry-configurationstable is quick succession.See open-telemetry/opentelemetry-configuration#100 for status of implementations.
cc @open-telemetry/configuration-maintainers