-
Notifications
You must be signed in to change notification settings - Fork 944
Use consistent vocabulary in reference to components and plugins #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use consistent vocabulary in reference to components and plugins #4806
Conversation
| The [configuration data model](./data-model.md) SHOULD support configuration of | ||
| all SDK extension plugin interfaces. SDKs SHOULD | ||
| support [registration](#register-componentprovider) of custom implementations of | ||
| SDK extension plugin interfaces via the `ComponentProvider` mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved up so all the normative language is centralized, leaving this section to just connect the dots of how plugin components are mapped.
…y-specification into consistent-component-vocabulary
|
This PR was marked stale. It will be closed in 14 days without additional activity. |
…y-specification into consistent-component-vocabulary
| * [Create Plugin](#create-plugin) | ||
| + [PluginComponentProvider](#plugincomponentprovider) | ||
| - [Supported SDK plugin components](#supported-sdk-plugin-components) | ||
| - [PluginComponentsProvider operations](#plugincomponentsprovider-operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [PluginComponentsProvider operations](#plugincomponentsprovider-operations) | |
| - [PluginComponentProvider operations](#plugincomponentprovider-operations) |
| | [log record processor](../logs/sdk.md#logrecordprocessor) | [LogRecordProcessor](https://github.com/open-telemetry/opentelemetry-configuration/blob/main/schema-docs.md#logrecordprocessor-) | | ||
|
|
||
| ##### ComponentsProvider operations | ||
| ##### PluginComponentsProvider operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ##### PluginComponentsProvider operations | |
| ##### PluginComponentProvider operations |
| ##### ComponentsProvider operations | ||
| ##### PluginComponentsProvider operations | ||
|
|
||
| The `ComponentsProvider` MUST provide the following functions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The `ComponentsProvider` MUST provide the following functions: | |
| The `PluginComponentProvider` MUST provide the following functions: |
In response to this feedback: #4568 (comment)
The declarative config SDK spec uses "component", "extension plugin interface", "SDK extension plugins" somewhat interchangeable.
This PR makes the vocabulary consistent:
To facilitate, this PR:
ComponentProvidertoPluginComponentProvider. This makes it clear that only plugins are being provided rather than all components.ComponentProvider.createPlugintoPluginComponentProvider.createComponent.There are no functional changes in this PR, just naming updates.