Skip to content

[Designate] Add Mdns replica count #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 23, 2024
Merged

[Designate] Add Mdns replica count #1207

openshift-merge-bot merged 1 commit into from
Dec 23, 2024

Conversation

@omersch381
Copy link
Contributor

@omersch381 omersch381 commented Nov 25, 2024

DesignateMdns deployment type is being changed to stateful set.

This commit adds replica count to Mdns in all the Designate CRs.

@openshift-ci openshift-ci bot requested review from dprince and jpodivin November 25, 2024 14:45
@omersch381 omersch381 requested a review from beagles November 25, 2024 14:45
@omersch381 omersch381 force-pushed the add_mdns_replica_count branch from 69b0dab to 4890a1f Compare November 25, 2024 16:59
@omersch381
Copy link
Contributor Author

omersch381 commented Nov 25, 2024

/retest

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 25, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3748e447acc04911858bf5c17610f5bb

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 05m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 23s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 49s
❌ adoption-standalone-to-crc-ceph-provider NODE_FAILURE Node request 099-0007680432 failed in 0s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 42m 27s

@omersch381
Copy link
Contributor Author

omersch381 commented Nov 26, 2024 •
edited
Loading

openstack-k8s-operators/designate-operator#255 will have to get merged first. Until then, CI will block this patch.

jpodivin
jpodivin requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Could you add an explicit depends on to this PR? Just so it's obvious that it's missing a dependency.

Also, it would be great to have a link to JIRA item, or some other description of what are you implementing and why. Thanks a lot.

@omersch381
Copy link
Contributor Author

omersch381 commented Nov 28, 2024 •
edited
Loading

Hi. Could you add an explicit depends on to this PR? Just so it's obvious that it's missing a dependency.

Also, it would be great to have a link to JIRA item, or some other description of what are you implementing and why. Thanks a lot.

Sure, thanks for raising it.

@omersch381 omersch381 force-pushed the add_mdns_replica_count branch 2 times, most recently from 12d1f02 to 5152399 Compare November 28, 2024 17:09
@omersch381
Copy link
Contributor Author

omersch381 commented Nov 29, 2024

The Designate-operator patch has been merged yesterday, and it added the Replicas field to the API directory files, I wonder when CI will stop failing because of lacking it.

@omersch381
Copy link
Contributor Author

omersch381 commented Nov 29, 2024

/retest

1 similar comment
@omersch381
Copy link
Contributor Author

omersch381 commented Dec 2, 2024

/retest

@omersch381 omersch381 requested a review from jpodivin December 2, 2024 11:52
@omersch381 omersch381 force-pushed the add_mdns_replica_count branch from 5152399 to 1e2b6fb Compare December 2, 2024 13:45
@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, omersch381

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
dprince
dprince reviewed Dec 9, 2024
View reviewed changes
config/samples/base/openstackcontrolplane/core_v1beta1_openstackcontrolplane.yaml
replicas: 1 # backend needs to be configured
designateMdns:
replicas: 0 # backend needs to be configured
replicas: 1 # backend needs to be configured
Copy link
Contributor

@dprince dprince Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment here says backend needs to be configured still. If you are setting replicas to 1 does this (and if functionally works) does this comment still make sense?

Copy link
Contributor Author

@omersch381 omersch381 Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is a generic comment that appear on many files. We are still configuring MiniDNS backend on the designate-operator repository, so I think it still applies.
This openstack-operator patch mainly saves us time, so we won't have to modify the csv manually with the same values. We modify its value to make sure changes in the current replica count will behave correctly with our changes.

@omersch381
Copy link
Contributor Author

omersch381 commented Dec 9, 2024

/retest

@omersch381
Copy link
Contributor Author

omersch381 commented Dec 17, 2024

#1204 has been merged

@omersch381
Copy link
Contributor Author

omersch381 commented Dec 17, 2024

/retest

@omersch381
[Designate] Add Mdns replica count
7da9ed3 
DesignateMdns deployment type is being changed to stateful set.

This commit adds replica count to Mdns in all the Designate CRs.

Depends-On: openstack-k8s-operators/designate-operator#255
Jira: https://issues.redhat.com/browse/OSPRH-11923
@omersch381 omersch381 force-pushed the add_mdns_replica_count branch from 1e2b6fb to 7da9ed3 Compare December 19, 2024 13:34
@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2024
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 19, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7350a4b012a34665a01d7d850fb3f00a

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 01m 25s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 41m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 29s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 43m 53s

@omersch381
Copy link
Contributor Author

omersch381 commented Dec 20, 2024

recheck podified-multinode-edpm-deployment-crc

@olliewalsh
Copy link
Contributor

olliewalsh commented Dec 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6aafc22 into openstack-k8s-operators:main Dec 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprince dprince dprince left review comments

@beagles beagles Awaiting requested review from beagles

@jpodivin jpodivin Awaiting requested review from jpodivin

+1 more reviewer

@bshephar bshephar bshephar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@olliewalsh olliewalsh

@bshephar bshephar

@jpodivin jpodivin

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@omersch381 @olliewalsh @dprince @bshephar @jpodivin