Skip to content

[Designate] Add Mdns replica count #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Dec 23, 2024
Merged

[Designate] Add Mdns replica count #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/samples/base/openstackcontrolplane/core_v1beta1_openstackcontrolplane.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ spec:
designateProducer:
replicas: 1 # backend needs to be configured
designateMdns:
replicas: 0 # backend needs to be configured
replicas: 1 # backend needs to be configured
Copy link
Contributor

@dprince dprince Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment here says backend needs to be configured still. If you are setting replicas to 1 does this (and if functionally works) does this comment still make sense?

Copy link
Contributor Author

@omersch381 omersch381 Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is a generic comment that appear on many files. We are still configuring MiniDNS backend on the designate-operator repository, so I think it still applies.
This openstack-operator patch mainly saves us time, so we won't have to modify the csv manually with the same values. We modify its value to make sure changes in the current replica count will behave correctly with our changes.

designateBackendbind9:
replicas: 1 # backend needs to be configured
storageClass: local-storage
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_galera.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_galera_3replicas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_galera_network_isolation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_galera_network_isolation_3replicas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_network_isolation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_network_isolation_ceph.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 1 addition & 1 deletion config/samples/core_v1beta1_openstackcontrolplane_network_isolation_tls_public_endpoint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ spec:
designateProducer:
replicas: 1
designateMdns:
replicas: 0
replicas: 1
networkAttachments:
- designate
designateBackendbind9:
Expand Down
2 changes: 2 additions & 0 deletions tests/kuttl/common/assert-sample-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ spec:
replicas: 1
designateCentral:
replicas: 1
designateMdns:
replicas: 1
designateWorker:
replicas: 1
designateProducer:
Expand Down
2 changes: 2 additions & 0 deletions tests/kuttl/tests/ctlplane-tls-cert-rotation/00-assert-deploy-openstack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ spec:
replicas: 1
designateCentral:
replicas: 1
designateMdns:
replicas: 1
designateWorker:
replicas: 1
designateProducer:
Expand Down
2 changes: 2 additions & 0 deletions tests/kuttl/tests/ctlplane-tls-cert-rotation/03-assert-new-certs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ spec:
replicas: 1
designateCentral:
replicas: 1
designateMdns:
replicas: 1
designateWorker:
replicas: 1
designateProducer:
Expand Down
2 changes: 2 additions & 0 deletions tests/kuttl/tests/ctlplane-tls-custom-issuers/01-assert-deploy-openstack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ spec:
replicas: 1
designateCentral:
replicas: 1
designateMdns:
replicas: 1
designateWorker:
replicas: 1
designateProducer:
Expand Down
2 changes: 2 additions & 0 deletions tests/kuttl/tests/ctlplane-tls-custom-issuers/09-assert-deploy-openstack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ spec:
replicas: 1
designateCentral:
replicas: 1
designateMdns:
replicas: 1
designateWorker:
replicas: 1
designateProducer:
Expand Down
2 changes: 2 additions & 0 deletions tests/kuttl/tests/ctlplane-tls-custom-route/03-assert-deploy-openstack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ spec:
replicas: 1
designateCentral:
replicas: 1
designateMdns:
replicas: 1
designateWorker:
replicas: 1
designateProducer:
Expand Down
Loading