Skip to content

feat: Add neutron function tools - subnet, port, floating ip #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
platanus-kr merged 15 commits into from
Aug 23, 2025
Merged

feat: Add neutron function tools - subnet, port, floating ip #46

platanus-kr merged 15 commits into from
Aug 23, 2025

Conversation

@platanus-kr
Copy link
Collaborator

@platanus-kr platanus-kr commented Aug 16, 2025 •
edited
Loading

Overview

  • Add Subnet, Port, Floating IP to Network Tools

Key Changes

[Subnet]

  • Create subnet
  • Retrieve subnet list
  • Retrieve subnet detail
  • Update subnet
  • Delete subnet
  • Config gateway
  • Remove gateway
  • Subnet DHCP Enbable/disable setup
  • Subnet DHCP status toggle

[Port]

  • Create port
  • Retrieve port list
  • Retrieve port detail
  • Update port
  • Delete port
  • Add port fixed IP
  • Remove port fixed IP
  • Get allowed address pairs
  • Add allowed address pairs
  • Remove allowes address pairs
  • Config port binding
  • Port state up setup
  • Port state down setup

[Floating IP]

  • Create floating IP
  • Retrieve floating IP list
  • Allocate pool to project
  • Attach floating IP to port (networking)
  • Detach floating IP to port (networking)
  • Delete floating IP
  • Update floating IP Description
  • Reassing floating IP to port
  • Create Bulk floating IP
  • Assign available floating IP

Related Issues

Additional context

.

@halucinor
Copy link
Collaborator

halucinor commented Aug 16, 2025

현재 develop 브랜치 기준으로 rebase 후 force push 부탁드립니다

halucinor
halucinor reviewed Aug 16, 2025
View reviewed changes
@halucinor halucinor added the feature Request for new feature or functionality enhancement label Aug 17, 2025
@platanus-kr platanus-kr force-pushed the feat/tool-neutron-function-subnet-port-floating-ip branch from 15d772d to 518ef4b Compare August 18, 2025 00:23
@platanus-kr platanus-kr changed the title feat:t Add neutron function tools - subnet port floating ip feat: Add neutron function tools - subnet, port, floating ip Aug 18, 2025
halucinor
halucinor requested changes Aug 18, 2025
View reviewed changes
@halucinor
Copy link
Collaborator

halucinor commented Aug 18, 2025

docstring 변경 필요사항

  • 해당 함수에서 직접 일으키지 않는 Exception 에 대한 주석 :raises Exception:
  • 메서드 주석으로 명시된 :type, :rtype (중복된 정보)

@platanus-kr platanus-kr force-pushed the feat/tool-neutron-function-subnet-port-floating-ip branch from e49a9a9 to cd91c73 Compare August 19, 2025 11:39
@platanus-kr
Copy link
Collaborator Author

platanus-kr commented Aug 20, 2025 •
edited
Loading

Floating IP는 아래와 같이 통합했습니다.

  • attach_floating_ip_to_port(), detach_floating_ip_from_port(), update_floating_ip_description(), reassign_floating_ip_to_port()
  • -> update_floating_ip()로 통합했습니다.

@platanus-kr platanus-kr force-pushed the feat/tool-neutron-function-subnet-port-floating-ip branch from 98cbac5 to 5e5c951 Compare August 20, 2025 12:39
S0okJu
S0okJu approved these changes Aug 22, 2025
View reviewed changes
Copy link
Collaborator

@S0okJu S0okJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

halucinor
halucinor reviewed Aug 23, 2025
View reviewed changes
Copy link
Collaborator

@halucinor halucinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNSET 변수에 대한 의견,

UNSET 변수는 업데이트 함수 내에서 값을 제거 하는 값으로 사용이 되는걸로 보입니다. 다만 이러한 방식의 변수 사용은 인자 해석을 난해하게 합니다. 인자를 사용하는대 있어 세가지 조건을 파악해야하는 상황이 되는대, 직관적으로 이해하기가 힘듭니다. 주석을 봐야 알 수 있는 내용 되버려서요.

UNSET 이라는 컨샙을 bool 인자로 추가하는게 더 나아보이는데 어떻게 생각하시나요?

halucinor
halucinor approved these changes Aug 23, 2025
View reviewed changes
Copy link
Collaborator

@halucinor halucinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halucinor
Copy link
Collaborator

halucinor commented Aug 23, 2025

Squash 머지 해주세요~

@platanus-kr platanus-kr merged commit 481dffd into develop Aug 23, 2025
6 checks passed
halucinor pushed a commit that referenced this pull request Aug 24, 2025
@platanus-kr @halucinor
feat: Add neutron function tools - subnet, port, floating ip (#46)
755a14d 
* feat(network): Add Subnet, Port, Floating IP tools (#30)

* feat(network): Add additional function in network tools (#30)

* feat(network): Add neutron tools function unit test (#30)

* fix(network): sphinx style comments (#30)

* fix(network): refactor code

- remove custom raise
- remove test case relation removing raise

* fix(network): typo change neutron to network (#30)

* fix(network): remove unused comments (#30)

* fix(network): remove unused allocate floating ip feature (#30)

* improve(network): integrating subnet update feature (#30)

* improve(network): integrating port update feature (#30)

* improve(network): integrating port update feature (#30)

* fix(network): alignment subnet model field (#30)

* chore(config): restore config

* fix(network): alignment port model field (#30)

* feat(network): add clear state arg to methods (#30)
@halucinor halucinor deleted the feat/tool-neutron-function-subnet-port-floating-ip branch August 25, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halucinor halucinor halucinor approved these changes

@S0okJu S0okJu S0okJu approved these changes

@choieastsea choieastsea Awaiting requested review from choieastsea

Assignees

No one assigned

Labels

feature Request for new feature or functionality enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@platanus-kr @halucinor @S0okJu