🌱 chore(lint): Upgrade golanglint from v2.7.2 to v2.8.0 and fix lint issues

[camilamacedo86]

No description provided.

[camilamacedo86]

@tmshort bingo get github.com/golangci/golangci-lint/v2/cmd/golangci-lint here is adding those,
I remember that we cannot add those ?
I think you did something to avoid it. Could you please help me out?
Can you please point out me how to fix it?

[tmshort]

I don't recall... :(

[camilamacedo86]

So it seems all is fine.
I think we cannot add those for operator-controller only doing the upstream/downstream dance.
Here shows all fine.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.47%. Comparing base (501f99b) to head (25cb920).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   57.48%   57.47%   -0.01%     
==========================================
  Files         138      138              
  Lines       13307    13307              
==========================================
- Hits         7649     7648       -1     
- Misses       4476     4477       +1     
  Partials     1182     1182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grokspawn]

I have some reservations because this is an update to a new version of bingo as well as a new version of golangci-lint.

Also, when we have lint issues here, we typically:

1. solve all test suggestions
2. solve any alpha/* or cmd/alpha/* (this includes the templates)
3. examine each case which remains, individually, with a bias towards putting in a //nolint comment instead. This code is pretty old and has some indirect failures.

I'll need another pass for 3 above.

Until then, please
/hold

[camilamacedo86]

Hi @grokspawn

Thank you for looking this one.

Regards: #1898 (comment)

We solved all suggestions.
Do you want to see the issues?
Sorry, I am not sure if I followed what would be required here.

[grokspawn]

Hi @grokspawn

Thank you for looking this one.

Regards: #1898 (comment)

We solved all suggestions. Do you want to see the issues? Sorry, I am not sure if I followed what would be required here.

Can we start by splitting this PR into two?

1. bingo version update
2. golangci-lint update and fixes

I have some concerns that the bingo updates might have impacts during vendor repackaging, so I'd prefer to see it handled disjointly.

What I was saying before is that the SQLite-related code is EOL and we generally do not touch it. I haven't made another pass to see if any proposed changes here are in that area, but I'll be happy to review the new PRs!