TST: Added test that checks if df.sum() results in concatenation instead of dtype coercion to float64 or int64 #63260
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs results in concatenation and not coercion to dtype int64 or float64
mroeschke
requested changes
Dec 4, 2025
Comment on lines
1050
to
1052
| df = DataFrame({"a": ["483", "3"], "b": ["94", "759"]}) | ||
| result = df.sum(axis=1) | ||
| expected = Series(["48394", "3759"]) |
Member
There was a problem hiding this comment.
Could you use pytest.mark.parametrize like
@pytest.mark.parametrize("input_data,expected_data", [[{"a": ...}, ["48394" ...]] ,...])so we don't have to repeat 3 separate setups?
Contributor
Author
There was a problem hiding this comment.
Yes I can. I will make these changes tonight and resubmit.
AbelJSanchez
commented
Dec 5, 2025
Contributor
Author
AbelJSanchez
left a comment
AbelJSanchez
left a comment
There was a problem hiding this comment.
Updated the test to use pytest.mark.parametrize instead of setting up three diferent assertions.
mroeschke
requested changes
Dec 5, 2025
Comment on lines
1050
to
1059
| DataFrame({"a": ["483", "3"], "b": ["94", "759"]}), | ||
| Series(["48394", "3759"]), | ||
| ), | ||
| ( | ||
| DataFrame({"a": ["483.948", "3.0"], "b": ["94.2", "759.93"]}), | ||
| Series(["483.94894.2", "3.0759.93"]), | ||
| ), | ||
| ( | ||
| DataFrame({"a": ["483", "3.0"], "b": ["94.2", "79"]}), | ||
| Series(["48394.2", "3.079"]), |
Member
There was a problem hiding this comment.
Can you put the DataFrame and Series calls in the body of the test?
Contributor
Author
There was a problem hiding this comment.
Yep. Will make changes tonight and resubmit.
AbelJSanchez
commented
Dec 6, 2025
Contributor
Author
AbelJSanchez
left a comment
AbelJSanchez
left a comment
There was a problem hiding this comment.
Updated test_sum_string_dtype() by moving the Series and DataFrame calls into the body of the test.
mroeschke
approved these changes
Dec 6, 2025
Member
|
Thanks @AbelJSanchez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test_sum_string_dtype_coercion() that checks if the df.sum() method results in in concatenation for numeric strings, and not coercion to dtype int64 or float64.
I wrote three different assertions:
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.