Merged
Conversation
This commit allows the maximum constraint to be entirely bypassed by setting the maximum property to 0 as some cases will not have a static maximum value.
…ddress' and 'detail' fields #745 The real maximum number of entries allowed in a specific table by pf varies by system. This commit ensures a static limit is not set for entries.
jaredhendrickson13
force-pushed
the
next_patch
branch
from
9db551e to
c2834dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
Fixes
addressanddetailitems were limited to a maximum of 128 items (API limitation: Cannot append individual IPs to existing firewall alias without hitting 128 IP limit #745)