Add support for 'reforge.current-time' property key #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds compatibility for the 'reforge.current-time' property key alongside the existing 'prefab.current-time' key. Both keys now provide the same current timestamp functionality for SDK compatibility. Changes: - Added REFORGE_CURRENT_TIME_KEY constant in ConfigRuleEvaluator - Updated prop() method to handle both time property keys - Added comprehensive test cases for both time key variants 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Add support for 'reforge.current-time' property key alongside existing 'prefab.current-time'
• Maintain backward compatibility while providing SDK compatibility with reforge naming
• Both property keys now provide identical current timestamp functionality
Changes
• Added
REFORGE_CURRENT_TIME_KEYconstant in ConfigRuleEvaluator• Updated
prop()method to handle both time property keys with OR condition• Added comprehensive test cases covering both time key variants
Test plan
This change maintains full backward compatibility while adding the requested reforge SDK compatibility.
🤖 Generated with Claude Code