Skip to content

Add support for 'reforge.current-time' property key #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkebinger merged 1 commit into from
Sep 22, 2025
Merged

Add support for 'reforge.current-time' property key #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/main/java/cloud/prefab/client/internal/ConfigRuleEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
public class ConfigRuleEvaluator {

public static final String CURRENT_TIME_KEY = "prefab.current-time";
public static final String REFORGE_CURRENT_TIME_KEY = "reforge.current-time";
private static final Logger LOG = LoggerFactory.getLogger(ConfigRuleEvaluator.class);

private final ConfigStore configStore;
Expand Down Expand Up @@ -242,7 +243,7 @@ private Optional<Prefab.ConfigValue> prop(
}
}
//TODO: move this current time injection into a ContextResolver class?
if (CURRENT_TIME_KEY.equals(key)) {
if (CURRENT_TIME_KEY.equals(key) || REFORGE_CURRENT_TIME_KEY.equals(key)) {
return Optional.of(
Prefab.ConfigValue.newBuilder().setInt(System.currentTimeMillis()).build()
);
Expand Down
51 changes: 51 additions & 0 deletions client/src/test/java/cloud/prefab/client/internal/ConfigRuleEvaluatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,57 @@ public void testTimeAfterRange() {
assertThat(eval.isMatch()).isFalse();
}

@Test
public void testReforgeTimeInRange() {
// note this relies on ConfigRuleEvaluator on-demand adding the current time for reforge.current-time
final Prefab.Criterion intRangeCriterion = Prefab.Criterion
.newBuilder()
.setPropertyName(ConfigRuleEvaluator.REFORGE_CURRENT_TIME_KEY)
.setValueToMatch(
Prefab.ConfigValue.newBuilder().setIntRange(Prefab.IntRange.newBuilder().build())
)
.setOperator(Prefab.Criterion.CriterionOperator.IN_INT_RANGE)
.build();

final EvaluatedCriterion positiveEval = evaluator
.evaluateCriterionMatch(intRangeCriterion, LookupContext.EMPTY)
.stream()
.findFirst()
.get();

assertThat(positiveEval.isMatch()).isTrue();
}

@Test
public void testReforgeTimeAfterRange() {
// note this relies on ConfigRuleEvaluator on-demand adding the current time for reforge.current-time
long currentTime = System.currentTimeMillis();

final Prefab.Criterion intRangeCriterion = Prefab.Criterion
.newBuilder()
.setPropertyName(ConfigRuleEvaluator.REFORGE_CURRENT_TIME_KEY)
.setValueToMatch(
Prefab.ConfigValue
.newBuilder()
.setIntRange(
Prefab.IntRange
.newBuilder()
.setEnd(currentTime - TimeUnit.MINUTES.toMillis(2))
.build()
)
)
.setOperator(Prefab.Criterion.CriterionOperator.IN_INT_RANGE)
.build();

final EvaluatedCriterion eval = evaluator
.evaluateCriterionMatch(intRangeCriterion, LookupContext.EMPTY)
.stream()
.findFirst()
.get();

assertThat(eval.isMatch()).isFalse();
}

public static Stream<Arguments> comparisonArguments() {
return Stream.of(
Arguments.of(
Expand Down