You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable React Compiler for ActionList — the foundational component used by ActionMenu, SelectPanel, NavList, and FilteredActionList.
ActionList was originally excluded from the compiler during the initial migration. After analysis (build, lint with eslint-plugin-react-compiler, and manual Storybook verification), all ActionList source files are fully compiler-compatible. The only fix needed was a Rules of Hooks violation in a story file.
Changes
Removesrc/ActionList/**/*.tsx from the React Compiler unsupported list in react-compiler.mjs
Fix a nested component definition in ChildWithSideEffects story — moved SideEffectDescription to module scope to comply with the Rules of Hooks
Why this matters
ActionList is the most-rendered list component in the design system. With the compiler enabled, React will automatically memoize ActionList's components (Item, List, Group, Selection, Visuals, etc.), reducing unnecessary re-renders without any manual React.memo / useMemo / useCallback work.
How did you test this change?
Lint — Ran npx eslint with react-compiler/react-compiler rule on all ActionList files (source, stories, tests): 0 warnings
- Remove ActionList from the React Compiler unsupported list
- Fix Rules of Hooks violation in ChildWithSideEffects story by
moving SideEffectDescription to module scope
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
integration-tests: recommended
Summary
Enable React Compiler for ActionList — the foundational component used by ActionMenu, SelectPanel, NavList, and FilteredActionList.
ActionList was originally excluded from the compiler during the initial migration. After analysis (build, lint with
eslint-plugin-react-compiler, and manual Storybook verification), all ActionList source files are fully compiler-compatible. The only fix needed was a Rules of Hooks violation in a story file.Changes
src/ActionList/**/*.tsxfrom the React Compiler unsupported list inreact-compiler.mjsChildWithSideEffectsstory — movedSideEffectDescriptionto module scope to comply with the Rules of HooksWhy this matters
ActionList is the most-rendered list component in the design system. With the compiler enabled, React will automatically memoize ActionList's components (
Item,List,Group,Selection,Visuals, etc.), reducing unnecessary re-renders without any manualReact.memo/useMemo/useCallbackwork.How did you test this change?
Lint — Ran
npx eslintwithreact-compiler/react-compilerrule on all ActionList files (source, stories, tests): 0 warningsBuild —
npx turbo build --filter=@primer/react --forcepasses cleanly with ActionList compiledStorybook — Verified the following stories render correctly with zero console warnings: