Skip to content

perf(ActionList): enable React Compiler #7537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hectahertz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(ActionList): enable React Compiler #7537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react/script/react-compiler.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const files = glob
})
const unsupported = new Set(
[
'src/ActionList/**/*.tsx',
'src/ActionMenu/**/*.tsx',
'src/AvatarStack/**/*.tsx',
'src/Button/**/*.tsx',
Expand Down
24 changes: 12 additions & 12 deletions packages/react/src/ActionList/ActionList.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,21 +667,21 @@ export const ConditionalChildren = () => {
)
}

export const ChildWithSideEffects = () => {
const user = users[0]
const [selected, setSelected] = React.useState(true)
const SideEffectDescription = () => {
const [seconds, setSeconds] = React.useState(0)

const SideEffectDescription = () => {
const [seconds, setSeconds] = React.useState(0)
React.useEffect(() => {
const fn = () => setSeconds(s => s + 1)
const interval = window.setInterval(fn, 1000)
return () => window.clearInterval(interval)
}, [])

React.useEffect(() => {
const fn = () => setSeconds(s => s + 1)
const interval = window.setInterval(fn, 1000)
return () => window.clearInterval(interval)
}, [])
return <>{seconds} seconds passed</>
}

return <>{seconds} seconds passed</>
}
export const ChildWithSideEffects = () => {
const user = users[0]
const [selected, setSelected] = React.useState(true)

return (
<ActionList selectionVariant="multiple" role="listbox" aria-label="Assignees">
Expand Down
Loading