Skip to content

Fix cell executor selection logic so bash cell execution works #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vezwork merged 2 commits into from
Jan 16, 2026
+7 −2
Merged

Fix cell executor selection logic so bash cell execution works #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c3ee9b
Fix cell executor selection logic so bash cell execution works
vezwork Sep 24, 2025
32ef84d
Add changelog entry
vezwork Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Fixed Copilot completions in `.qmd` documents (<https://github.com/quarto-dev/quarto/pull/887>).
- Fixed a bug where the `autoDetectColorScheme` setting could cause equation previews to have a dark text on dark background and vice versa (<https://github.com/quarto-dev/quarto/pull/864>).
- Fix a regression where bash cell execution does not work (<https://github.com/quarto-dev/quarto/pull/826>).

## 1.128.0 (Release on 2026-01-08)

Expand Down
8 changes: 6 additions & 2 deletions apps/vscode/src/host/executors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,11 @@ const csharpCellExecutor: VSCodeCellExecutor = {
const bashCellExecutor: VSCodeCellExecutor = {
language: "bash",
execute: async (blocks: string[]) => {
const terminal = window.activeTerminal || window.createTerminal();
// todo: this should probably check that the terminal isn't an interactive terminal for languages
// other than R as well...
const terminal = window.activeTerminal && window.activeTerminal?.name !== 'R Interactive' ?
window.activeTerminal : window.createTerminal();

terminal.show();
terminal.sendText(blocks.join("\n"));
},
Expand Down Expand Up @@ -283,7 +287,7 @@ export async function ensureRequiredExtension(
}
}
} else {
return false;
return true;
}
}

Expand Down