Update fixture for __toString() when parent mixed return, to always add string, as work on DowngradeStringReturnTypeOnToStringRector#272
Merged
samsonasik merged 1 commit intomainfrom May 2, 2025
Conversation
…dd string, as work
Member
|
Will this cause any bugs? |
Member
Author
|
it is ok, since |
Member
Author
|
@TomasVotruba ok, if it has another child, than it cause error if not downgraded (shippped product that downgraded - consumed by user), I will update to use AstResolver for it on separate PR |
Member
Author
|
@TomasVotruba possible bug if downgraded code consumed by user https://3v4l.org/kdcEh#v7.4.33 I will create separate PR with AstResolver 👍 |
Member
Author
|
@TomasVotruba I created PR on rector-src to cover it: and revert this fixture change. |
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems due to this change phpstan/phpstan-src@3854cbc
It seems the only way we can do is just follow it since it not error when set as magic https://3v4l.org/IrE2q#v7.4.33
This PR update the fixture.