Skip to content

Comments

[PHPStan 2.1.14] Fix resolve __toString() parent non builtin method without return type#6879

Merged
samsonasik merged 3 commits intomainfrom
fix-to-string
May 2, 2025
Merged

[PHPStan 2.1.14] Fix resolve __toString() parent non builtin method without return type#6879
samsonasik merged 3 commits intomainfrom
fix-to-string

Conversation

@samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

@TomasVotruba fixed and fixture reverted on rectorphp/rector-downgrade-php#273 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 394eb49 into main May 2, 2025
45 checks passed
@samsonasik samsonasik deleted the fix-to-string branch May 2, 2025 18:56
@samsonasik
Copy link
Member Author

samsonasik commented May 2, 2025

I created PR to phpstan-src for possible solution there so we can back to original implementation to avoid this hack if accepted on phpstan side:

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants