Downgrade pipe operator

[arshidkv12]

No description provided.

[arshidkv12]

Rector\Tests\DowngradePhp85\Rector\StmtsAwareInterface\DowngradePipeOperatorRector\DowngradePipeOperatorRectorTest::test with data set #0 ('/home/runner/work/rector-down...hp.inc')
PHPStan\Parser\ParserErrorsException: Syntax error, unexpected '>', Syntax error, unexpected '>', Syntax error, unexpected '>'

How to fix it?

[samsonasik]

That somehow cause php < 8.5 error, probably issue on phpstan internal parser.

[samsonasik]

You can add PHP 8.5 to workflow, then add:

use PHPUnit\Framework\Attributes\RequiresPhp;

// ..
#[RequiresPhp('>= 8.5')]

on test method.

[samsonasik]

Add php 8.5 as well here

rector-downgrade-php/.github/workflows/tests.yaml

Line 24 in ffa9fe4

php-version: 8.2

[samsonasik]

@arshidkv12 could you create separate PR for workflow CI update? That's to allow enabled by @TomasVotruba then another PR can keep working without waiting for:

TestsExpected — Waiting for status to be reported

before waiting this PR merged.

[arshidkv12]

@samsonasik Ok

[samsonasik]

The rule need to be registered at

https://github.com/rectorphp/rector-downgrade-php/blob/main/config/set/downgrade-php85.php

[samsonasik]

Also, please run:

vendor/bin/rector && composer fix-cs

[samsonasik]

why clone is needed? should direct replace args works?

[samsonasik]

this increment can use NamedVariableFactory::createVariable() to allow first not replace existing $result variable.

rector-downgrade-php/src/NodeFactory/NamedVariableFactory.php

Lines 19 to 24 in 2c4aa18

	public function createVariable(string $variableName, Expression $expression): Variable
	{
	$scope = $expression->getAttribute(AttributeKey::SCOPE);
	$variableName = $this->variableNaming->createCountedValueName($variableName, $scope);
	return new Variable($variableName);

that will do the increment

[samsonasik]

why clone is needed? should direct replace args works?

[samsonasik]

I will look into this to mirror with upgrade rule PR:

• [PHP 8.5] Add NestedToPipeOperatorRector rector-src#7577