[Alternative 1] Don't change to assertSame() on numeric string on AssertEqualsToSameRector #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
| return true; | ||
| } | ||
|
|
||
| return $args[0]->value instanceof String_ && is_numeric($args[0]->value->value); |
Member
|
Looks good 👍 I recall we use this approach in some other rules too, good job |
Member
Author
|
@TomasVotruba hm.., I still got error even on --- Expected
+++ Actual
@@ @@
-'123'
+'0000000000000000000123'seems because of "string", that |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this is alternative solution to not change to
assertSameon numeric string for failure test https://github.com/rectorphp/rector-phpunit/actions/runs/17128495249/job/48586074883#step:5:43