Skip to content

Conversation

@samsonasik
Copy link
Member

@TomasVotruba per #520 (comment) I tested in our project, the change on assertEquals still invalid on "123" vs "0000000000000000000123"

--- Expected
+++ Actual
@@ @@
-'123'
+'0000000000000000000123'

This patch skip assertEquals on convert.

The converting string to int also needs consideration tho, but that when I found another error.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test in our project ;)

@samsonasik samsonasik merged commit db71441 into main Aug 22, 2025
6 checks passed
@samsonasik samsonasik deleted the skip-assert-equals branch August 22, 2025 12:38
@TomasVotruba
Copy link
Member

I see, it's because of internal casting of PHP. Thanks for fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants