Narrow object return type v2 #7618
Merged
TomasVotruba merged 7 commits intorectorphp:mainfrom Nov 27, 2025
Merged
Conversation
samsonasik
requested changes
Nov 10, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
please move parent class/interface to Source directory
samsonasik
reviewed
Nov 10, 2025
rules/TypeDeclaration/Rector/ClassMethod/NarrowObjectReturnTypeRector.php
Show resolved
Hide resolved
Orest-Divintari
force-pushed
the
orest/narrow-object-return-type-to-include-parent
branch
from
efb3a2a to
17943df
Compare
Member
|
Let's ship this. Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to this #7575 , this PR extends the rule to narrow return types from any supertype (interfaces, abstract classes, and parent classes) to the actual concrete class being returned.
Before this change:
Only narrowed when parent method had object type or no parent method existed
After this change:
Narrows interfaces, abstract classes, parent classes to the actual returned class