[internal] re-index changed nodes only

[TomasVotruba]

Split of #7651

[samsonasik]

There is called on ChangedNodeScopeRefresher::refresh() as well, see:

rector-src/src/Application/ChangedNodeScopeRefresher.php

Lines 61 to 63 in fff99ae

	// reindex stmt_key already covered on StmtKeyNodeVisitor on next processNodes()
	// so set flag $reIndexStmtKey to false to avoid double loop
	NodeAttributeReIndexer::reIndexNodeAttributes($node, false);

while there disable sort order stmt keys.

Actually, possible bug may happen by only on after refactor, eg: when it returns remove node, which key is from parent, which means the order should be before processing as well, as next visitor may from parent, which the key not yet ordered.

[samsonasik]

Also, the reindex needs on $refactoredNode, not a $node as it means before refactored.

[TomasVotruba]

Ideally create a PR with failing test fixture on real rule we have, so we got it covered.

[TomasVotruba]

I'll investigate 👍

[samsonasik]

I created PR:

• Remove NodeAttributeReIndexer::reIndexNodeAttributes() on AbstractRector #7652

to use on ChangedNodeScopeRefresher