[fix] avoid changing generic interface in NarrowObjectReturnTypeRector, focus on objects as in definition#7700
Merged
TomasVotruba merged 1 commit intomainfrom Dec 2, 2025
Merged
Conversation
…r, focus on objects as in definition
TomasVotruba
force-pushed
the
tv-skip-interface-replace
branch
from
1765474 to
7b6b936
Compare
samsonasik
reviewed
Dec 2, 2025
| } | ||
|
|
||
| // this rule narrows only object or class types, not interfaces | ||
| if (! $declaredTypeClassReflection->isClass()) { |
Member
There was a problem hiding this comment.
On private method, change return interface to actual class should be allowed, since private method usually not be mockable in test, and not follow any contract.
Member
There was a problem hiding this comment.
staabm
reviewed
Dec 3, 2025
| } | ||
|
|
||
| // this rule narrows only object or class types, not interfaces | ||
| if (! $declaredTypeClassReflection->isClass()) { |
Contributor
There was a problem hiding this comment.
I think it should also not narrow on abstract class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've accidenally merged a different feature than intended. The
NarrowObjectReturnTypeRectorreplaced not only objects, but also interfaces. That goes against desired behavior, from PHPStan rule https://github.com/rectorphp/type-perfect#5-narrow-return-typesIt should not replae interfaces, moreover generic ones, as those allow easy replacement with different class and make code readable. That would scope of some
ReplaceInterfaceWithObjectReturnTypeRector:) but it doesn't make sense for making code less readable.Saying that, I'm narrowing (pun intended) this rule to handle only
objectand more general/astractobjects 👍Closes rectorphp/rector#9525