[TypeDeclaration] Allow interface return change to exact return on private method on NarrowObjectReturnTypeRector#7701
Closed
samsonasik wants to merge 2 commits intomainfrom
Closed
[TypeDeclaration] Allow interface return change to exact return on private method on NarrowObjectReturnTypeRector#7701samsonasik wants to merge 2 commits intomainfrom
samsonasik wants to merge 2 commits intomainfrom
Conversation
…ivate method on NarrowObjectReturnTypeRector
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
As stated in my PR, this rule handles only classes. Nothing else. Keep it simple :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #7700 (review)
private method is not part of contract, and usualyl not mockable or to be mockable by test, so changing interface return type on private method should be allowed.