Implement squiggly heredocs for the parser translator #3341
Conversation
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
2 times, most recently
from
a179339 to
02c0a66
Compare
| is_first_token_on_line = lexed[index - 1] && token.location.start_line != lexed[index - 2][0].location&.start_line | ||
| # The parser gem only removes indentation when the heredoc is not nested | ||
| not_nested = heredoc_stack.size == 1 | ||
| if is_first_token_on_line && not_nested && (heredoc = heredoc_stack[0]).common_whitespace > 0 |
There was a problem hiding this comment.
Any tip for getting this through sorbet? It complains that heredoc can be nil but that will never be the case because the previous condition checked that the first element is present.
When rewriting this into something that proves to sorbet that it can't be nil, it's telling me that the condition is always falsy.
This also fails:
index = 0
lexed = [:FIRST, :SECOND]
length = lexed.length
identifiers = []
while index < length
token = lexed[index]
index += 1
case token
when :FIRST
identifiers.push("abc")
when :SECOND
if (identifier = identifiers[0])
puts identifier
end
end
endIt seems to believe that the array is always empty
There was a problem hiding this comment.
Got a workaround from sorbet/sorbet#8401 (comment) that seems to work
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
from
02c0a66 to
302cc30
Compare
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
from
302cc30 to
8bbdc4f
Compare
In parser, the string content is dedented. This implements these rules as far as I was able to understand them. It's all a bit confusing with spaces/tabs, always learning more funny things about them. I refered to the prism implementation, parser seems to adhere to it very closely.
Earlopain
force-pushed
the
parser-translator-squigly-heredoc
branch
from
8bbdc4f to
7bfd527
Compare
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Wow, amazing work. I don't know that I can properly review this because obviously the code is quite complex. But the tests are passing and you've got even more tests passing, so I'm assuming this is working. Nice job!
2 participants
In parser, the string content is dedented. This implements these rules as far as I was able to understand them. It's all a bit confusing with spaces/tabs, always learning more funny things about them.
I refered to the prism implementation, parser seems to adhere to it very closely.