WIP: Improve the build-artifacts GitHub action
#3389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Package the headers along with the binary 2. Package `libprism.a` instead of the dynamically built binary
egiurleo
force-pushed
the
upload-headers-during-release
branch
from
34115e4 to
4ea019e
Compare
paracycle
reviewed
Jan 10, 2025
| files: | | ||
| build/libprism.so | ||
| build/libprism.dylib | ||
| files: prism-${{ matrix.os }}.tar.gz |
Collaborator
There was a problem hiding this comment.
I am not sure if this will be enough, since for mac and linux we still need to differentiate between arm64 and amd64 platforms, etc.
Besides, IMO prism-macos-latest.tar.gz is a weird name for the package.
Contributor
Author
There was a problem hiding this comment.
Sounds good, I can look more into the differences between arm64 and amd64.
Member
There was a problem hiding this comment.
Based on this chart, it looks like to run amd64 macOS we need to add macos-13 to the os matrix too.
egiurleo
changed the title
build-artifacts GitHub actionbuild-artifacts GitHub action
Contributor
Author
|
Closed in favor of #3391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore this for now -- working on the best approach!
Follow up to #3272
After doing some testing on the Sorbet project, we realized that we want to package pre-built headers along with a binary (because some of the headers are only generated during the compilation process), and also that Bazel works a lot better with static libraries, hence uploading
libprism.arather than thedyliborsofile.I tested this job on the Shopify fork to make sure it still works.