Skip to content

WIP: Improve the build-artifacts GitHub action #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
egiurleo wants to merge 1 commit into from
Closed

WIP: Improve the build-artifacts GitHub action #3389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/build-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,17 @@ jobs:
- name: Build library
run: bundle exec rake compile

- name: Package files
run: |
mkdir dist
cp -r include dist/
cp build/libprism.a dist/
tar -czf prism-${{ matrix.os }}.tar.gz -C dist .

- name: Upload to release
if: github.event_name == 'release'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: softprops/action-gh-release@v2
with:
files: |
build/libprism.so
build/libprism.dylib
files: prism-${{ matrix.os }}.tar.gz
Copy link
Collaborator

@paracycle paracycle Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this will be enough, since for mac and linux we still need to differentiate between arm64 and amd64 platforms, etc.

Besides, IMO prism-macos-latest.tar.gz is a weird name for the package.

Copy link
Contributor Author

@egiurleo egiurleo Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I can look more into the differences between arm64 and amd64.

Copy link
Member

@st0012 st0012 Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this chart, it looks like to run amd64 macOS we need to add macos-13 to the os matrix too.

Loading