Fix bundle console printing bug report template incorrectly
#8436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's initialized again later on.
LoadError is not a RuntimeError.
It's simpler.
This local variable is initialized later on in this file.
At this point, `dep.autorequire` is always nil.
If a gem has an internal error, that should not make `bundle console` print the bug report template.
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 17, 2025
Fix `bundle console` printing bug report template incorrectly (cherry picked from commit 55bd82a)
Earlopain
added a commit
to Earlopain/rubygems
that referenced
this pull request
Jun 30, 2025
…ng require Followup to ruby#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
4 tasks
Earlopain
added a commit
to Earlopain/rubygems
that referenced
this pull request
Jun 30, 2025
…ng require Followup to ruby#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
Earlopain
added a commit
to Earlopain/rubygems
that referenced
this pull request
Jun 30, 2025
…ng require Followup to ruby#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
Earlopain
added a commit
to Earlopain/rubygems
that referenced
this pull request
Jun 30, 2025
…ng require Followup to ruby#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
deivid-rodriguez
pushed a commit
to Earlopain/rubygems
that referenced
this pull request
Jul 1, 2025
…ng require Followup to ruby#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 2, 2025
… on `NameError` during require Followup to ruby/rubygems#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library. ruby/rubygems@1c910e5afe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I run
bundle consoleon an application and it crashed with a Bundler bug report template. However, there was not any issue in Bundler. The gem had a problem where a Ruby gem had been moved to a bundled gem and the dependency was not being declared in the gems gemspec. But that's an internal error, independent of Bundler, so it should not encourage users to report bugs to us.What is your fix for the problem, implemented in this PR?
My fix is to change
Bundler.requireto not raiseLoadError's but raise instead internal expected Bundler errors that are properly handled.Make sure the following tasks are checked