Deprecate legacy windows platforms (:mswin, :mingw) in Gemfile DSL in favor of :windows
#8447
Conversation
johnnyshields
force-pushed
the
deprecate-legacy-windows-platforms2
branch
from
d6e815e to
3bd3ee1
Compare
|
@deivid-rodriguez ready for your review. |
There was a problem hiding this comment.
@deivid-rodriguez Updated based on your feedback, thank you.
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Mind rebasing and squashing everything to a single commit?
|
Oh, some additional specs that only run in "bundler 3 mode" need to be updated too. |
deivid-rodriguez
force-pushed
the
deprecate-legacy-windows-platforms2
branch
from
cf3addb to
ccc374a
Compare
|
I fixed the small issues CI had found, merging! |
|
Well, the specs just showed that 96496e3 actually broke caching gems when legacy windows platforms are specified. Will look into it closer to see what we can do about it. It went unnoticed because there's a bug in the |
|
I created #8482 to fix that issue. |
Co-authored-by: johnnyshields <27655+johnnyshields@users.noreply.github.com>
… in favor of using `platform :windows` This commit is only deprecation and does not change/remove any actual functionality.
deivid-rodriguez
force-pushed
the
deprecate-legacy-windows-platforms2
branch
from
ccc374a to
0ca6dc3
Compare
|
Thanks Deivid, really appreciate your help to get this merged! 🎉 |
deivid-rodriguez
changed the title
platform :windows:mswin, :mingw) in Gemfile DSL in favor of :windows
2 participants
Replaces PR #8379
Background
For over 2 years, Rails has included
gem "tzinfo-data", platforms: %i[ windows jruby ]in its default Gemfile. The usage of:windowsas a platform value is being widely adopted.The Change
In the Gemfile DSL, this PR deprecates platform the following platform values
:mswin, :mswin64, :mingw, :x64_mingwin favor of:windows. In addition, some related aliased methods are commented as deprecated.This PR does not change/remove any actual functionality.