[Tests failing] Bunder DSL platform method: Deprecate legacy Windows values (:mingw, etc.) in favor of :windows. #8379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…win64, :mingw, :x64_mingw in favor of using :windows. This PR also fully unifies their behavior to be identical to :windows, i.e. they no longer are specific to their given architectures as there are basically no gems which are architecture specific. (We've already done lots of unification of these already with no user pushback and this PR finishes the job.) This PR also deprecates the associated Gem::Platform constants in favor of WINDOWS; these are unlikely to be used externally.
johnnyshields
changed the title
johnnyshields
commented
Jan 2, 2025
| [Gem::Platform.new("mswin32"), Gem::Platform.new("windows")], | ||
| [Gem::Platform.new("mswin64"), Gem::Platform.new("windows")], | ||
| [Gem::Platform.new("mingw32"), Gem::Platform.new("windows")], | ||
| [Gem::Platform.new("mingw"), Gem::Platform.new("windows")], |
Contributor
Author
There was a problem hiding this comment.
For the purposes of generics, I've introduced a new virtual OS value "windows" which doesn't actually exist in the wild. Please let me know if I should map all these to "mingw" instead.
johnnyshields
changed the title
johnnyshields
changed the title
Contributor
Author
|
Replaced by #8447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8378. Please merge that PR first.
Background
For over 2 years, Rails has included
gem "tzinfo-data", platforms: %i[ windows jruby ]in its default Gemfile. The usage of:windowsas a platform value is being widely adopted.The Change
This PR deprecates platform the following platform values
:mswin, :mswin64, :mingw, :x64_mingwin favor of:windows.This PR also fully unifies their "generic platform" behavior to be identical to
:windows, as there is no longer any real-world use case where one would want to install a given gem for one flavor of windows but not another. We've already done lots of unification of these platforms already with no user pushback and this PR finishes the job.This PR also deprecates the associated
Gem::Platformconstants in favor ofWINDOWS; these are unlikely to be used externally.To further clarify:
x64-mingw-ucrtwill continue to be specific to only those architectures (i.e. they will not be mistakenly installed on anx64-mswin64machine, for example.)