-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Support "mingw" generically as a Windows OS architecture (support for aarch64-mingw-ucrt) #8378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for upcoming arm64-windows architecture.
8327321 to
3ba3fe1
Compare
|
@deivid-rodriguez can you please take a look at this as well as PR #8379? I'm trying to figure out the direction I should go here... I'm thinking possibly we should make "windows" something more akin to how generic "ruby" platform works today (so basically "windows", "java" and "ruby" are the 3 generic platforms.) |
|
Thank you @johnnyshields for working on this issue and notifying me! I can confirm it fixes platform mapping issue in oneclick/rubyinstaller2#399 . 👍 |
|
I'll look into this @johnnyshields 👍, thanks! |
|
In my opinion using I’d be happy to see that |
|
@deivid-rodriguez, the Ruby Installer for Windows ARM is now available 🎉 It would be great if you could help look at this soon so we can start using Windows on ARM? |
|
Yep, thanks for the ping. I was planning to start looking into this this week. |
|
@johnnyshields I started looking into this, and I ended up introducing a fair amount of additional changes, so I created a separate PR to supersede this one. See #8428. I tried to implement the approach suggested by @ntkme. Please give it a try! |
|
Closing in favor of #8428. |
Currently the logic for detecting
mingwis too strict. It needs to be loosened to support upcomingaarch64-mingw-ucrtarchitecture. See this PR: oneclick/rubyinstaller2#399See also: #8379