Fix legacy Windows :platform values no longer working
#8482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should always run.
Otherwise it doesn't work as expected and it may skip specs.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-legacy-windows-platform-filters
branch
from
a71098a to
d6af077
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/fix-legacy-windows-platform-filters
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 17, 2025
…ndows-platform-filters Fix legacy Windows `:platform` values no longer working (cherry picked from commit dab1f9a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
#8428 created a regression when using legacy
mingwplatform values in Gemfile. One spec would've caught the issue, because there was an issue in the RSpec filter it was using, so the spec was being skipped.What is your fix for the problem, implemented in this PR?
The fix is to make sure the legacy values are still matched after the changes in #8428 by mapping them to
universal-mingwas well. I also fixed the filter to catch this kind of issue in the future.Make sure the following tasks are checked