Implement hidden RPC addconnection
#433
Conversation
jamillambert
force-pushed
the
1217-hidden-addconnection
branch
from
0d6509d to
783833e
Compare
|
CI failure is unrelated #434. EDIT: CI now passes, but no changes were made to the code that caused the failure. |
jamillambert
force-pushed
the
1217-hidden-addconnection
branch
from
783833e to
b453c71
Compare
|
Can be rebased now mate. |
jamillambert
force-pushed
the
1217-hidden-addconnection
branch
from
b453c71 to
1aa95d1
Compare
|
Rebased, no changes. |
0xB10C
left a comment
0xB10C
left a comment
There was a problem hiding this comment.
Looks good to me.
Having this in https://github.com/peer-observer/peer-observer/tree/master/extractors/p2p will make the integration tests a lot easier and less brittle, thanks!
client/src/client_sync/v27/hidden.rs
Outdated
| //! Macros for implementing JSON-RPC methods on a client. | ||
| //! | ||
| //! Specifically this is `== Hidden ==` methods that are not listed in the | ||
| //! API docs of Bitcoin Core `v29`. |
There was a problem hiding this comment.
not sure?
| //! API docs of Bitcoin Core `v29`. | |
| //! API docs of Bitcoin Core `v27`. |
There was a problem hiding this comment.
Thanks, I've changed it.
jamillambert
force-pushed
the
1217-hidden-addconnection
branch
from
1aa95d1 to
a36ccc6
Compare
types/src/model/hidden.rs
Outdated
| /// Models the result of JSON-RPC method `addconnection`. | ||
| #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)] | ||
| pub struct AddConnection { | ||
| /// The address of the newly added connection. | ||
| pub address: String, | ||
| /// Type of connection. | ||
| pub connection_type: String, | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't need this in model because there are no concrete types from rust-bitcoin, only Strings.
There was a problem hiding this comment.
Yep I did extra work for no reason. I just saw address and thought needs a model, and obviously never removed it once I realised it was a network address.
Removed now.
|
Everything else looks good. Reviewed: a36ccc6 |
Implement the RPC in v22 hidden module, add the client macro, model and test. Redefine the client macro in v27 where there is an added required argument. Add all the reexports up to v30.
jamillambert
force-pushed
the
1217-hidden-addconnection
branch
from
a36ccc6 to
224200d
Compare
3 participants
Implement the RPC in v22 hidden module, add the client macro, model and test.
Redefine the client macro in v29 where there is an added required argument.
Add all the reexports up to v30.