Update SBT, Scala.js, Scala Native, and plugins #716
Conversation
|
Thanks @keynmol! But with the sbt update there are some changes with the way all the cross versions are set up. That's where the work actually is, and I didn't have time to dig into. |
|
I am assuming that SBT 1.7.0 is the one introducing changes to how cross versions work: https://github.com/sbt/sbt/releases/tag/v1.7.0
Which is in contrast with the way runtime and reporter are set up in this project. I added a couple of hacks to see how the tests go (they pass locally), but we can think of an actual fix |
| libraryDependencies += "org.scala-lang" % "scala-compiler" % scalaVersion.value % Provided, | ||
| sharedSettings | ||
| sharedSettings, | ||
| allowUnsafeScalaLibUpgrade := true |
There was a problem hiding this comment.
We should also set runtime to have allowUnsafeScalaLibUpgrade := true,, we should be ok to do that.
Or alternatively ask Seb to release Scala JS 2.13.17 on 1.19.0
Alternatively, do we need to cross publish JS on every Scala version as well?
There was a problem hiding this comment.
@ckipp01 if you'd like I can help with day to day maintenance, is it possible to add me to the repo?
There was a problem hiding this comment.
Scala.js 1.20.1 support for 2.13.17 is published.
We will not publish earlier versions, as they predate the Sonatypocalypse. Their build cannot publish to the new Central Portal.
https://contributors.scala-lang.org/t/scala-2-13-17-release-planning/6994/18
There was a problem hiding this comment.
You can change the build and release manually, though maybe with Scala JS it's much harder.
There was a problem hiding this comment.
@ckipp01 if you'd like I can help with day to day maintenance, is it possible to add me to the repo?
Yup, just added you. Everything is set up for creds to publish on a tag, everything just needs to be updated. You should have access to the sbt repo as well, but that one is up to date.
There was a problem hiding this comment.
If the problem is supporting older Scala 2.13 versions, could we drop support for older versions and support only the latest 2.13.17? People can still use older versions of scoverage (which is very stable) for these older Scala versions and use the latest only if they are on Scala 2.12.20 and 2.13.17.
There was a problem hiding this comment.
It shouldn't be an issue for now. Let me fix up the PR
There was a problem hiding this comment.
ech, it seems Scala JS plugin is wrecking havoc now :/
There was a problem hiding this comment.
Ok, I give up, I will remove the older version support and if we need there is ways to backport fixes. I can take care of that if needed (famous last words)
|
Thanks @keynmol for your work! I opened the PR with my changes added on top of it and squashed it together. |
5 participants
My understanding is that this should be enough for publishing as long as the credentials in this repo have been rotate since the Central Portal migratio.