-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: fix JavaScript lint errors (issue #9687) #9690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
| // Cache the most recent results... | ||
| if ( arguments.length > 1 ) { | ||
| args = new Array( arguments.length-1 ); | ||
| args = new Array( arguments.length-1 ); // eslint-disable-line stdlib/no-new-array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct change. This should have been converted to [] and then use #.push in the loop.
| var COL_MAJOR_REV_PIVOTS_IPIV_STRIDE = require( './fixtures/column_major_reverse_pivots_ipiv_stride.json' ); // eslint-disable-line id-length | ||
| var COL_MAJOR_REV_PIVOTS_IPIV_OFFSET = require( './fixtures/column_major_reverse_pivots_ipiv_offset.json' ); // eslint-disable-line id-length | ||
| var COL_MAJOR_K1 = require( './fixtures/column_major_k1.json' ); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also isn't the desired change. Here we actually want the empty line in order to visually group related fixtures. The lint rule should have been disabled here.
PR-URL: stdlib-js#9690 Closes: stdlib-js#9687 Ref: stdlib-js#5377 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #9687
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers