Skip to content

chore: fix JavaScript lint errors (issue #9687) #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Planeshifter merged 1 commit into from
Jan 11, 2026
Merged

chore: fix JavaScript lint errors (issue #9687) #9690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/node_modules/@stdlib/lapack/base/claswp/test/test.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ var COL_MAJOR_REV_PIVOTS = require( './fixtures/column_major_reverse_pivots.json
var COL_MAJOR_REV_PIVOTS_IPIV_STRIDE = require( './fixtures/column_major_reverse_pivots_ipiv_stride.json' ); // eslint-disable-line id-length
var COL_MAJOR_REV_PIVOTS_IPIV_OFFSET = require( './fixtures/column_major_reverse_pivots_ipiv_offset.json' ); // eslint-disable-line id-length
var COL_MAJOR_K1 = require( './fixtures/column_major_k1.json' );

Copy link
Member

@kgryte kgryte Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also isn't the desired change. Here we actually want the empty line in order to visually group related fixtures. The lint rule should have been disabled here.

var ROW_MAJOR = require( './fixtures/row_major_no_offsets.json' );
var ROW_MAJOR_IPIV_STRIDE_POS = require( './fixtures/row_major_ipiv_stride_positive.json' );
var ROW_MAJOR_IPIV_OFFSET = require( './fixtures/row_major_ipiv_offset.json' );
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/utils/async/do-while/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function doWhileAsync( fcn, predicate, done, thisArg ) {

// Cache the most recent results...
if ( arguments.length > 1 ) {
args = new Array( arguments.length-1 );
args = new Array( arguments.length-1 ); // eslint-disable-line stdlib/no-new-array
Copy link
Member

@kgryte kgryte Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct change. This should have been converted to [] and then use #.push in the loop.

for ( i = 1; i < arguments.length; i++ ) {
args[ i-1 ] = arguments[ i ];
}
Expand Down