Skip to content

Conversation

@tokoko
Copy link
Contributor

@tokoko tokoko commented Jan 5, 2026

No description provided.

@benbellick
Copy link
Member

I've never heard of pixi before so I may just not understand. But is there a reason we couldn't just use uv in CI, considering that we already have a uv.lock file checked in?

@tokoko
Copy link
Contributor Author

tokoko commented Jan 5, 2026

it's just a faster alternative to conda, written in rust of course 😆 you can't configure system dependencies with uv (antlr, buf and protoc in this case). this PR only changes codegen check to use pixi which used whole devcontainer before. tests are still run with only uv. Although maybe it might make sense to port everything to pixi in the future as well for simplicity, not sure.

@tokoko tokoko changed the title chore: use pixi for environment in ci chore: use pixi for codegen environment in ci Jan 5, 2026
@giospada
Copy link
Contributor

giospada commented Jan 6, 2026

Can you update the CONTRIBUTING.md?

@tokoko
Copy link
Contributor Author

tokoko commented Jan 6, 2026

done, also upgraded libprotobuf to latest in pixi as well

Co-authored-by: Niels Pardon <mail@niels-pardon.de>
lint = "ruff check"
lint_fix = "ruff check --fix"

update-submodule = "./update_submodule.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels to me for the time being (until substrait-io/substrait#925) one would always run codegen after updating the submodule. what do you think about linking them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aka update-submodule triggers codegen but you can still do codegen independently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out you can't link them like this update-submodule = [ "./update_submodule.sh", { task = "codegen" }], so I added another update-substrait task that runs both instead.

Copy link
Member

@nielspardon nielspardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much nicer approach with pixi

@tokoko tokoko merged commit 8aa2a78 into substrait-io:main Jan 7, 2026
20 checks passed
@tokoko tokoko deleted the pixi branch January 7, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants