-
Notifications
You must be signed in to change notification settings - Fork 17
chore: use pixi for codegen environment in ci #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
aeca6ad
chore: use pixi for environment in ci
tokoko ef3c673
fix: run check with pixi
tokoko ed02578
fix: add uv to pixi
tokoko 9deaec5
chore: regenerate protos with pixi protoc
tokoko 049439d
chore: upgrade libprotobuf
tokoko 79d1ff2
fix: drop libprotobuf from env
tokoko ac43d32
fix: add linux-aarch64 to pixi platforms
tokoko 92020f7
fix: codegen with pixi only
tokoko 2c827c2
fix: devcontainer and docs
tokoko ecdb52b
chore: try moving command to pixi tasks
tokoko 5861d61
chore: migrate make commands to pixi tasks
tokoko 1414bb6
fix: codegen workflow
tokoko 5ac67c2
chore: rename update-proto to update-submodule
tokoko 9e748c3
Update .github/workflows/codegen-check.yml
tokoko 72bcbb9
chore: add update-substrait task
tokoko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,5 @@ | ||
| FROM mcr.microsoft.com/vscode/devcontainers/python:3.13 | ||
| USER vscode | ||
| RUN curl -s "https://get.sdkman.io" | bash | ||
| RUN bash -c "source $HOME/.sdkman/bin/sdkman-init.sh && \ | ||
| sdk install java 25-graalce" | ||
| RUN mkdir -p ~/lib && cd ~/lib && curl -L -O http://www.antlr.org/download/antlr-4.13.2-complete.jar | ||
| ENV ANTLR_JAR="~/lib/antlr-4.13.2-complete.jar" | ||
| RUN cd ~ && curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v33.2/protoc-33.2-linux-x86_64.zip && \ | ||
| unzip protoc-33.2-linux-x86_64.zip -d ~/.local && \ | ||
| rm protoc-33.2-linux-x86_64.zip | ||
| RUN curl -sSL "https://github.com/bufbuild/buf/releases/download/v1.58.0/buf-$(uname -s)-$(uname -m)" -o ~/.local/bin/buf && chmod +x ~/.local/bin/buf | ||
| RUN curl -LsSf https://astral.sh/uv/install.sh | sh | ||
| USER root | ||
| RUN curl -fsSL https://pixi.sh/install.sh | sh | ||
| ENV PATH=~/.pixi/bin:$PATH | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| src/substrait/gen/** linguist-generated=true | ||
| src/substrait/extensions/** linguist-generated=true | ||
| # SCM syntax highlighting & preventing 3-way merges | ||
| pixi.lock merge=binary linguist-language=YAML linguist-generated=true -diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,3 +142,6 @@ src/substrait/_version.py | |
| .directory | ||
| .gdb_history | ||
| .DS_Store | ||
| # pixi environments | ||
| .pixi/* | ||
| !.pixi/config.toml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/bin/bash | ||
| if ! git diff --quiet --exit-code src/substrait/gen/; then | ||
| echo "Code generation produced changes. Generated code is out of sync!" | ||
| echo "" | ||
| git diff src/substrait/gen/ | ||
| echo "" | ||
| echo "To fix this, run:" | ||
| echo " pixi run codegen" | ||
| echo "Then commit the changes." | ||
| exit 1 | ||
| fi |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.