fix: remove pin from backup and reset pin settings on restore #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical security issue where PIN-related settings (biometric authentication and PIN requirement for payments) were being backed up without the actual PIN, creating an impossible authentication state after restore. The solution removes PIN settings from the backup configuration and ensures these settings are always reset during the restore process.
Key Changes:
- Removed PIN-related settings from backup configuration to prevent authentication state mismatch
- Added automatic PIN settings reset during the restore process
- Aligned iOS behavior with existing Android implementation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Bitkit/Models/SettingsBackupConfig.swift | Removed useBiometrics and requirePinForPayments from backup mappings with explanatory comment |
| Bitkit/Services/BackupService.swift | Added PIN settings reset call after successful restore operation |
ben-kaufman
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PIN settings (useBiometrics, requirePinForPayments) were being backed up but PIN wasn't. This created an impossible authentication state after restore
Solution: Don't backup pin settings and always reset pin settings on restore
OBS: Android already implemented this same solution
Linked Issues/Tasks
Close #304
Screenshot / Video
reset-pin.mp4