Skip to content

fix: remove pin from backup and reset pin settings on restore #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvsena42 merged 2 commits into from
Jan 7, 2026
+6 −2
Merged

fix: remove pin from backup and reset pin settings on restore #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
211ca1e
fix: remove pin from backup and reset pin on restore
jvsena42 Jan 7, 2026
aa19dda
chore: await resetPinSettings
jvsena42 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Bitkit/Models/SettingsBackupConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ enum SettingsBackupConfig {
"warnWhenSendingOver100": "enableSendAmountWarning",
"bitcoinDisplayUnit": "displayUnit",
"enableQuickpay": "isQuickPayEnabled",
"useBiometrics": "isBiometricEnabled",
"requirePinForPayments": "isPinForPaymentsEnabled",
"enableNotifications": "notificationsGranted",
// Note: PIN settings are intentionally NOT backed up for security
// PIN itself cannot be backed up, so PIN settings shouldn't be either
]

static let algorithmMapping: [String: String] = [
Expand Down
3 changes: 3 additions & 0 deletions Bitkit/Services/BackupService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ class BackupService {
}

Logger.info("Full restore success", context: "BackupService")

// Always reset PIN settings after restore (PIN is never backed up for security)
await SettingsViewModel.shared.resetPinSettings()
} catch {
Logger.warn("Full restore error: \(error)", context: "BackupService")
}
Expand Down
1 change: 1 addition & 0 deletions Bitkit/ViewModels/Extensions/SettingsViewModel+PIN.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ extension SettingsViewModel {
pinFailedAttempts = 0
}

@MainActor
func resetPinSettings() {
pinEnabled = false
pinFailedAttempts = 0
Expand Down
Loading