Skip to content

Comments

fix(charts): use bitnamilegacy repo for MinIO Object Browser#2592

Merged
nicktrn merged 2 commits intotriggerdotdev:mainfrom
LeoKaynan:fix/bitnamilegacy-minio-object-browser
Oct 7, 2025
Merged

fix(charts): use bitnamilegacy repo for MinIO Object Browser#2592
nicktrn merged 2 commits intotriggerdotdev:mainfrom
LeoKaynan:fix/bitnamilegacy-minio-object-browser

Conversation

@LeoKaynan
Copy link
Contributor

The Bitnami minio-object-browser image has been removed from Docker Hub. This patch updates the Trigger Helm chart to reference the bitnamilegacy/minio-object-browser repository under the s3.console.image section, ensuring that the legacy MinIO browser pod can still be deployed without image pull errors.

All other MinIO components continue using the bitnamilegacy/minio image for consistency across Bitnami Legacy dependencies.

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

Deployed the chart locally using:

helm upgrade --install trigger \
  oci://ghcr.io/triggerdotdev/charts/trigger-v4 \
  -f values.yaml

Confirmed that both S3 pods (trigger-s3 and trigger-s3-console) start successfully and use the expected images:

kubectl get pod trigger-s3-console-xxxx -o jsonpath='{.spec.containers[0].image}'

Output:

docker.io/bitnamilegacy/minio-object-browser:2025.1.10-debian-12-r1

No ImagePullBackOff or missing image errors were observed.


Changelog


Screenshots

[Screenshots]
image

💯

The Bitnami `minio-object-browser` image has been removed from Docker
Hub. This patch updates the Trigger Helm chart to reference the
`bitnamilegacy/minio-object-browser` repository under the
`s3.console.image` section, ensuring that the legacy MinIO browser pod
can still be deployed without image pull errors.

All other MinIO components continue using the `bitnamilegacy/minio`
image for consistency across Bitnami Legacy dependencies.
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: 3ae6d66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

Walkthrough

  • hosting/k8s/helm/Chart.yaml: Helm chart version updated from 4.0.3 to 4.0.4; appVersion unchanged.
  • hosting/k8s/helm/values.yaml: Introduces a new s3.console configuration block for the MinIO Console (Browser UI), including an image configuration with repository set to bitnamilegacy/minio-object-browser and a commented example tag. No existing keys modified or removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description includes a detailed summary, checklist, testing steps, and a screenshot but omits the required “Closes #” statement and leaves the Changelog section blank, so it does not fully conform to the repository’s template. Please add a “Closes #” directive referencing the relevant issue or remove that header if none applies, and fill the Changelog section with a brief summary of the version bump and console image update.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely describes the main change of updating the Helm chart to use the Bitnami Legacy repository for the MinIO Object Browser and follows the repository’s conventional commit style.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64fcc88 and 3ae6d66.

📒 Files selected for processing (2)
  • hosting/k8s/helm/Chart.yaml (1 hunks)
  • hosting/k8s/helm/values.yaml (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-06-25T13:18:44.103Z
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#2195
File: hosting/k8s/helm/Chart.yaml:1-18
Timestamp: 2025-06-25T13:18:44.103Z
Learning: For the Trigger.dev Helm chart, the chart name should be "trigger" (not "trigger-v4") since this is the first official chart release. Helper templates should use the actual chart name from .Chart.Name rather than hardcoded prefixes.

Applied to files:

  • hosting/k8s/helm/Chart.yaml
📚 Learning: 2025-06-25T13:20:17.174Z
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#2195
File: hosting/k8s/helm/values.yaml:22-51
Timestamp: 2025-06-25T13:20:17.174Z
Learning: In the Trigger.dev Helm chart values.yaml, the maintainer prefers to use explicit comprehensive warnings for security-sensitive default values rather than implementing secure-by-default behavior that would fail installation. The project uses deterministic default secrets with clear "TESTING ONLY" warnings and instructions for production deployment.

Applied to files:

  • hosting/k8s/helm/Chart.yaml
📚 Learning: 2025-06-25T13:18:04.827Z
Learnt from: nicktrn
PR: triggerdotdev/trigger.dev#2195
File: hosting/k8s/helm/templates/extra-manifests.yaml:1-4
Timestamp: 2025-06-25T13:18:04.827Z
Learning: In the Trigger.dev v4 Helm chart, the user prefers to rely on documentation and examples in values files rather than implementing defensive coding in templates, particularly for features like extraManifests where proper usage is documented.

Applied to files:

  • hosting/k8s/helm/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
  • GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
  • GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
  • GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: typecheck / typecheck
🔇 Additional comments (2)
hosting/k8s/helm/values.yaml (1)

605-610: Console image override wired correctly.

Switching the console image to the Bitnami Legacy repo keeps the MinIO console aligned with the rest of the legacy stack and matches the tested pull reference.

hosting/k8s/helm/Chart.yaml (1)

5-5: Chart version bump looks good.

Incrementing to 4.0.4 correctly tracks the values change without disturbing the app version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@nicktrn nicktrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeoKaynan will release this asap!

@nicktrn nicktrn merged commit f5caa66 into triggerdotdev:main Oct 7, 2025
26 checks passed
@LeoKaynan LeoKaynan deleted the fix/bitnamilegacy-minio-object-browser branch October 7, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants