feat(timeout): add benchmarking support and optimize signal handling #9100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dev-dependencies for divan and uucore with benchmark features to Cargo.toml - Include a new benchmark harness for timeout_bench - Optimize signal lookups using OnceLock for KILL and CONT signals to avoid repeated computations - Introduce preserved_child_exit function for accurate exit status handling - Update send_signal and wait_or_kill_process for improved efficiency and correctness - Update Cargo.lock with new dependency codspeed-divan-compat This enhances performance testing capabilities and reduces overhead in signal operations for the timeout utility.
|
GNU testsuite comparison: |
Contributor
- Include uu_timeout utility in the GitHub Actions benchmarks workflow - Ensures performance metrics are collected for the newly added timeout command
|
GNU testsuite comparison: |
… unused test - Reduced sleep time in "long-sleep" mode from 2s to 200ms for faster execution - Shortened timeout values in quick_exit and enforced benchmarks from 0.1s/0.05s to 0.02s - Removed timeout_kill_after benchmark to streamline test suite and improve performance
Removed unnecessary blank lines after the bench_timeout_with_mode call in src/uu/timeout/benches/timeout_bench.rs to improve code readability and consistency.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Collaborator
|
Whats the reason that this PR is combined? Would it be possible to split the benchmarking and the timeout enhancements? |
Contributor
Author
separate PR |
Contributor
|
needs #9733 before merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances performance testing capabilities and reduces overhead in signal operations for the timeout utility.