feat(timeout): add benchmarking support with divan #9733

mattsu2020 · 2025-12-20T05:43:50Z

Add dev-dependencies for divan and uucore benchmarking features, and configure a new bench target for timeout command performance testing. This enables automated benchmarking to track and optimize execution times.

related
#9100 (comment)

Add dev-dependencies for divan and uucore benchmarking features, and configure a new bench target for timeout command performance testing. This enables automated benchmarking to track and optimize execution times.

github-actions · 2025-12-20T07:58:01Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

sylvestre

some jobs are failing

github-actions · 2025-12-22T10:45:24Z

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

mattsu2020 · 2025-12-22T11:02:34Z

some jobs are failing

This is a temporary error.

sylvestre · 2025-12-22T12:42:32Z

it seems that divan isn't identifying these new benchmarks

Remove the unnecessary `mod unix` block and use `#[cfg(unix)]` attributes on imports, functions, and benchmarks. Adjust `main()` to conditionally call `divan::main()` for Unix platforms. This refactoring improves code readability and reduces module nesting without changing functionality.

github-actions · 2025-12-22T13:16:37Z

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

github-actions · 2025-12-23T13:26:15Z

GNU testsuite comparison:

Congrats! The gnu test tests/tail/inotify-dir-recreate is now passing!

Include benchmarking for the uu_timeout utility to ensure performance tracking alongside other tools in the suite.

github-actions · 2025-12-24T10:29:05Z

GNU testsuite comparison:

GNU test failed: tests/sort/sort-stale-thread-mem. tests/sort/sort-stale-thread-mem is passing on 'main'. Maybe you have to rebase?

github-actions · 2025-12-26T07:45:21Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

src/uu/timeout/benches/timeout_bench.rs

… logic Replace complex child mode spawning with direct command arguments for cleaner and more maintainable benchmarks, reducing overhead and improving readability. Use "true" for quick-exit and "sleep" for enforced timeout tests.

github-actions · 2025-12-31T00:44:01Z

GNU testsuite comparison:

Congrats! The gnu test tests/cp/preserve-gid is no longer failing!
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-01-14T05:31:04Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/follow-name is no longer failing!

src/uu/timeout/benches/timeout_bench.rs

Remove the shared bench_timeout function and directly inline its logic into timeout_quick_exit and timeout_enforced benchmarks. This simplifies the code by eliminating unnecessary abstraction for two closely related functions.

github-actions · 2026-01-14T08:11:11Z

GNU testsuite comparison:

Congrats! The gnu test tests/sort/sort-float is no longer failing!

codspeed-hq · 2026-01-15T11:43:47Z

Merging this PR will improve performance by 3.75%

⚡ 1 improved benchmark
✅ 185 untouched benchmarks
🆕 1 new benchmark
⏩ 134 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Memory	`dd_copy_default`	130.8 KB	126 KB	+3.75%
🆕	Simulation	`timeout_enforced`	N/A	186.1 µs	N/A

_{Comparing mattsu2020:timeout-bench-only-clean (03a63f7) with main (d0c7e12)}

134 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-01-15T11:48:06Z

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

This update ensures compatibility with the latest features and bug fixes in the divan benchmarking library.

Disable the benchmark function for the fast path where the command exits immediately, as it may be redundant or causing issues in the test suite.

sylvestre · 2026-01-18T08:52:26Z

still draft, is that expected ?

Enable Rust backtraces in the benchmarks workflow to aid in troubleshooting failures during performance testing.

- Changed RUST_BACKTRACE from "1" to "full" to provide more detailed backtraces for better debugging in case of errors during benchmark runs.

…go-codspeed Replace separate dtolnay/rust-toolchain, rust-cache, and sccache actions with moonrepo/setup-rust@v1 for unified setup. This aligns toolchain and binary versions with CodSpeed to prevent memtrack/cargo-codspeed incompatibilities, ensuring reliable benchmark builds.

Add "memtrack" and "moonrepo" to the spell-checker ignore list to prevent false positives for new benchmarking tools introduced in the workflow.

Uncommented the timeout_quick_exit benchmark function to include testing of the fast path where the command exits immediately, ensuring performance metrics are captured for this scenario.

github-actions · 2026-01-18T11:05:33Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

The moonrepo/setup-rust action requires 'channel' instead of 'rust-version' for specifying the Rust version. Updated the parameter to ensure the workflow executes correctly.

github-actions · 2026-01-18T13:32:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

Fixed a full-width space character in the Rust channel version to a standard space, preventing potential parsing issues in the GitHub Actions workflow.

mattsu2020 · 2026-01-18T14:22:51Z

still draft, is that expected ?

The memory investigation for timeout always fails.
This seems to be an issue with CodSpeed memtrack v1.1.0, so this PR cannot be merged for the time being.

github-actions · 2026-01-18T14:23:54Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

codspeed-hq · 2026-01-18T14:26:30Z

Unable to generate the performance report

There was an internal error while processing the run's data. We're working on fixing the issue. Feel free to contact us on Discord or at support@codspeed.io if the issue persists.

feat(timeout): add benchmarking support with divan

847740e

Add dev-dependencies for divan and uucore benchmarking features, and configure a new bench target for timeout command performance testing. This enables automated benchmarking to track and optimize execution times.

mattsu2020 mentioned this pull request Dec 20, 2025

feat(timeout): add benchmarking support and optimize signal handling #9100

Open

mattsu2020 added 2 commits December 20, 2025 15:15

Merge branch 'main' into timeout-bench-only-clean

2bbf44e

Merge branch 'main' into timeout-bench-only-clean

d8dedda

sylvestre requested changes Dec 22, 2025

View reviewed changes

Merge branch 'main' into timeout-bench-only-clean

10bd153

Merge branch 'main' into timeout-bench-only-clean

81d7354

ci: add uu_timeout to benchmarks

52cd47f

Include benchmarking for the uu_timeout utility to ensure performance tracking alongside other tools in the suite.

Merge branch 'main' into timeout-bench-only-clean

d032ed1

mattsu2020 requested a review from sylvestre December 26, 2025 07:41

Merge branch 'main' into timeout-bench-only-clean

98d6a10

sylvestre reviewed Dec 30, 2025

View reviewed changes

src/uu/timeout/benches/timeout_bench.rs Show resolved Hide resolved

mattsu2020 requested a review from sylvestre January 5, 2026 08:53

Merge branch 'main' into timeout-bench-only-clean

2459c4c

sylvestre reviewed Jan 14, 2026

View reviewed changes

src/uu/timeout/benches/timeout_bench.rs Outdated Show resolved Hide resolved

refactor(bench): inline timeout benchmark logic

8fe8bf8

Remove the shared bench_timeout function and directly inline its logic into timeout_quick_exit and timeout_enforced benchmarks. This simplifies the code by eliminating unnecessary abstraction for two closely related functions.

Merge branch 'main' into timeout-bench-only-clean

b53bcb5

mattsu2020 and others added 2 commits January 16, 2026 20:20

Merge branch 'main' into timeout-bench-only-clean

4f9b2b7

chore(deps): update divan package version from 4.0.5 to 4.2.1

a6d14cc

This update ensures compatibility with the latest features and bug fixes in the divan benchmarking library.

mattsu2020 marked this pull request as draft January 16, 2026 12:39

mattsu2020 and others added 2 commits January 16, 2026 21:40

chore(benches): comment out timeout_quick_exit benchmark

effde91

Disable the benchmark function for the fast path where the command exits immediately, as it may be redundant or causing issues in the test suite.

Merge branch 'main' into timeout-bench-only-clean

5a0da40

mattsu2020 added 5 commits January 18, 2026 19:25

ci(benchmarks): add RUST_BACKTRACE env var for debugging

656c486

Enable Rust backtraces in the benchmarks workflow to aid in troubleshooting failures during performance testing.

fix(ci): update RUST_BACKTRACE to "full" in benchmarks workflow

03a63f7

- Changed RUST_BACKTRACE from "1" to "full" to provide more detailed backtraces for better debugging in case of errors during benchmark runs.

ci: update spell-checker ignore list in benchmarks workflow

a60e79b

Add "memtrack" and "moonrepo" to the spell-checker ignore list to prevent false positives for new benchmarking tools introduced in the workflow.

perf: enable benchmark for timeout quick exit path

4cf18ad

Uncommented the timeout_quick_exit benchmark function to include testing of the fast path where the command exits immediately, ensuring performance metrics are captured for this scenario.

fix(ci): correct Rust version parameter in benchmarks workflow

b17989d

The moonrepo/setup-rust action requires 'channel' instead of 'rust-version' for specifying the Rust version. Updated the parameter to ensure the workflow executes correctly.

fix(ci): correct spacing in benchmarks workflow Rust channel

cfdb321

Fixed a full-width space character in the Rust channel version to a standard space, preventing potential parsing issues in the GitHub Actions workflow.

Uh oh!

feat(timeout): add benchmarking support with divan #9733

Are you sure you want to change the base?

feat(timeout): add benchmarking support with divan #9733

Conversation

mattsu2020 commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025

Uh oh!

sylvestre left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

mattsu2020 commented Dec 22, 2025

Uh oh!

sylvestre commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 31, 2025

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

codspeed-hq bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 3.75%

Performance Changes

Footnotes

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

mattsu2020 commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

codspeed-hq bot commented Jan 18, 2026

Unable to generate the performance report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Jan 15, 2026 •

edited

Loading