Skip to content

Conversation

@joel16
Copy link
Contributor

@joel16 joel16 commented Jan 25, 2025

Also updated the following github actions:

  • actions/checkout@v3 -> actions/checkout@v4
  • actions/upload-artifact@v3 -> actions/upload-artifact@v4
  • actions/setup-python@v2 -> actions/setup-python@v5

Comment on lines +56 to +57
name: vitasdk-linux-arm64
path: build/*.tar.bz2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm.... most parts are looks good to me.
just i'm worried that this upload could make trouble in ci chain to detect linux binaries.

https://github.com/vitasdk/vita-headers/blob/master/.travis.d/last_built_toolchain.py

a script doesn't check the arch yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... it wouldn't related actual ci chains of other projects... i'll check it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual ci is autobuilds's workflow.
this patch would safe. i'll merge it after ci checking of the linux & linux-arm64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks!

@d3m3vilurr d3m3vilurr merged commit 09c533b into vitasdk:master Jan 29, 2025
2 of 4 checks passed
@joel16 joel16 deleted the linux-arm64 branch January 29, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants